linux-kernel - RE: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001101d8f449$c78f8010$56ae8030$@samsung.com>
Date:   Wed, 9 Nov 2022 20:14:28 +0530
From:   "Aakarsh Jain" <aakarsh.jain@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
        <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <ezequiel@...guardiasur.com.ar>, <jernej.skrabec@...il.com>,
        <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <alim.akhtar@...sung.com>, <aswani.reddy@...sung.com>,
        <pankaj.dubey@...sung.com>, <smitha.t@...sung.com>
Subject: RE: [Patch v2 1/3] arm: exynos: Add new compatible string for
 Exynos3250 SoC.



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 09 November 2022 14:31
> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> david.plowman@...pberrypi.com; mark.rutland@....com;
> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> pankaj.dubey@...sung.com; smitha.t@...sung.com
> Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for
> Exynos3250 SoC.
> 
> On 09/11/2022 04:55, Aakarsh Jain wrote:
> > Since,MFC v7 support was added for Exynos5420 and Exynos
> > 3250 SoC with same compatible string "samsung,mfc-v7".As both SoCs
> > having different hardware properties and having same compatible string
> > for both SoCs doesn't seems to be correct.
> > New compatible is added for Exynos3250 SOC which will differentiate
> > the node properties for both SoCs which support MFC v7.
> >
> > Reviewed-by: Tommaso Merciai
> <tommaso.merciai@...rulasolutions.com>
> > Suggested-by: Alim Akhtar <alim.akhtar@...sung.com>
> > Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
> > ---
> >  Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
As with recent commits on Documentation/devicetree/bindings/media/s5p-mfc.txt with git log --oneline --  ,  subject prefix doesn't seems to be consistent.

b1394dc151cb media: s5p-mfc: Adding initial support for MFC v10.10
60641e22599a [media] s5p-mfc: Use preallocated block allocator always for MFC v6+
003611334d55 [media] s5p-mfc: Add support for MFC v8 available in Exynos 5433 SoCs
0da658704136 ARM: dts: convert to generic power domain bindings for exynos DT
77634289286a ARM: dts: Update clocks entry in MFC binding documentation
2eae613b95a7 ARM: EXYNOS: Add MFC device tree support

Closest is ARM: dts.
so what is your suggestion on this?

Anyway we are in a process of converting this txt file to yaml . 


> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested
> changes or keep discussing them.
> 
> Thank you.
> 
> Best regards,
> Krzysztof

Thanks for the review.