lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202211101322.ZmMz4GOz-lkp@intel.com>
Date:   Thu, 10 Nov 2022 13:51:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     'Guanjun' <guanjun@...ux.alibaba.com>, herbert@...dor.apana.org.au,
        elliott@....com
Cc:     oe-kbuild-all@...ts.linux.dev, zelin.deng@...ux.alibaba.com,
        artie.ding@...ux.alibaba.com, guanjun@...ux.alibaba.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        xuchun.shang@...ux.alibaba.com
Subject: Re: [PATCH v3 RESEND 4/9] crypto/ycc: Add device error handling
 support for ycc hw errors

Hi 'Guanjun',

Thank you for the patch! Yet something to improve:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v6.1-rc4 next-20221109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221103-154448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/1667461243-48652-5-git-send-email-guanjun%40linux.alibaba.com
patch subject: [PATCH v3 RESEND 4/9] crypto/ycc: Add device error handling support for ycc hw errors
config: xtensa-allyesconfig
compiler: xtensa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e5dd94f77cbf5e4ca1f2b9bd365b5d1e12324984
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221103-154448
        git checkout e5dd94f77cbf5e4ca1f2b9bd365b5d1e12324984
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/pgtable.h:6,
                    from include/linux/kasan.h:33,
                    from include/linux/slab.h:148,
                    from drivers/crypto/ycc/ycc_ring.c:8:
   arch/xtensa/include/asm/pgtable.h:20:33: error: expected identifier before numeric constant
      20 | #define USER_RING               1       /* user ring level */
         |                                 ^
   drivers/crypto/ycc/ycc_ring.h:28:9: note: in expansion of macro 'USER_RING'
      28 |         USER_RING,
         |         ^~~~~~~~~
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_ring_debugfs_status_show':
   drivers/crypto/ycc/ycc_ring.c:40:41: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
      40 |         seq_printf(s, "CMD base addr:%llx, RESP base addr:%llx\n",
         |                                      ~~~^
         |                                         |
         |                                         long long unsigned int
         |                                      %x
      41 |                    ring->cmd_base_paddr, ring->resp_base_paddr);
         |                    ~~~~~~~~~~~~~~~~~~~~  
         |                        |
         |                        dma_addr_t {aka unsigned int}
   drivers/crypto/ycc/ycc_ring.c:40:62: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
      40 |         seq_printf(s, "CMD base addr:%llx, RESP base addr:%llx\n",
         |                                                           ~~~^
         |                                                              |
         |                                                              long long unsigned int
         |                                                           %x
      41 |                    ring->cmd_base_paddr, ring->resp_base_paddr);
         |                                          ~~~~~~~~~~~~~~~~~~~~~
         |                                              |
         |                                              dma_addr_t {aka unsigned int}
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_init_ring':
   drivers/crypto/ycc/ycc_ring.c:193:22: error: 'KERN_RING' undeclared (first use in this function); did you mean 'KERNEL_RING'?
     193 |         ring->type = KERN_RING;
         |                      ^~~~~~~~~
         |                      KERNEL_RING
   drivers/crypto/ycc/ycc_ring.c:193:22: note: each undeclared identifier is reported only once for each function it appears in
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_select_ring':
   drivers/crypto/ycc/ycc_ring.c:374:44: error: 'KERN_RING' undeclared (first use in this function); did you mean 'KERNEL_RING'?
     374 |                         if (found->type != KERN_RING) {
         |                                            ^~~~~~~~~
         |                                            KERNEL_RING
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_cancel_cmd':
   drivers/crypto/ycc/ycc_ring.c:489:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     489 |         aflag = (struct ycc_flags *)desc->private_ptr;
         |                 ^
   drivers/crypto/ycc/ycc_ring.c:490:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     490 |         if (!aflag || (u64)aflag == CMD_INVALID_CONTENT_U64) {
         |                       ^
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_handle_resp':
   drivers/crypto/ycc/ycc_ring.c:539:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     539 |         aflag = (struct ycc_flags *)desc->private_ptr;
         |                 ^
   drivers/crypto/ycc/ycc_ring.c:540:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     540 |         if (!aflag || (u64)aflag == CMD_INVALID_CONTENT_U64) {
         |                       ^
   drivers/crypto/ycc/ycc_ring.c: In function 'ycc_clear_resp_ring':
>> drivers/crypto/ycc/ycc_ring.c:646:30: error: 'INVAL_RING' undeclared (first use in this function)
     646 |                 ring->type = INVAL_RING;
         |                              ^~~~~~~~~~


vim +/INVAL_RING +646 drivers/crypto/ycc/ycc_ring.c

   603	
   604	/*
   605	 * Clear response queue
   606	 *
   607	 * Note: Make sure been invoked when error occurs in YCC internal and
   608	 * YCC status is not ready.
   609	 */
   610	void ycc_clear_resp_ring(struct ycc_ring *ring)
   611	{
   612		struct ycc_resp_desc *resp;
   613		int retry;
   614		u32 pending_cmd;
   615	
   616		/*
   617		 * Check if the ring has been stopped. *stop* means no
   618		 * new transactions, No need to wait for pending_cmds
   619		 * been processed under this condition.
   620		 */
   621		retry = ycc_ring_stopped(ring) ? 0 : MAX_ERROR_RETRY;
   622		pending_cmd = YCC_CSR_RD(ring->csr_vaddr, REG_RING_PENDING_CMD);
   623	
   624		ring->resp_wr_ptr = YCC_CSR_RD(ring->csr_vaddr, REG_RING_RSP_WR_PTR);
   625		while (!ycc_ring_empty(ring) || (retry && pending_cmd)) {
   626			if (!ycc_ring_empty(ring)) {
   627				resp = (struct ycc_resp_desc *)ring->resp_base_vaddr +
   628					ring->resp_rd_ptr;
   629				resp->state = CMD_CANCELLED;
   630				ycc_handle_resp(ring, resp);
   631	
   632				if (++ring->resp_rd_ptr == ring->max_desc)
   633					ring->resp_rd_ptr = 0;
   634	
   635				YCC_CSR_WR(ring->csr_vaddr, REG_RING_RSP_RD_PTR, ring->resp_rd_ptr);
   636			} else {
   637				udelay(MAX_SLEEP_US_PER_CHECK);
   638				retry--;
   639			}
   640	
   641			pending_cmd = YCC_CSR_RD(ring->csr_vaddr, REG_RING_PENDING_CMD);
   642			ring->resp_wr_ptr = YCC_CSR_RD(ring->csr_vaddr, REG_RING_RSP_WR_PTR);
   643		}
   644	
   645		if (!retry && pending_cmd)
 > 646			ring->type = INVAL_RING;

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (317405 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ