linux-kernel - Re: [PATCH V3 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c616858-3de9-6de5-bfee-572bf0405ec1@quicinc.com>
Date:   Thu, 10 Nov 2022 12:33:52 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     Doug Anderson <dianders@...omium.org>
CC:     <jinghung.chen3@...mail.com>, <agross@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <robh+dt@...nel.org>,
        <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH V3 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm
 reference boards as LTE

Hey Doug,

Thanks for taking time to review the series.

On 11/9/22 23:10, Doug Anderson wrote:
> Hi,
> 
> On Tue, Nov 8, 2022 at 9:51 PM Sibi Sankar <quic_sibis@...cinc.com> wrote:
>>
>> When the modem node was re-located to a separate LTE source file
>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
>> weren't marked appropriately. Fix this by marking all Qualcomm
>> reference devices as LTE.
>>
>> Suggested-by: Douglas Anderson <dianders@...omium.org>
>> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
>> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
>> ---
>>
>> v3:
>>   * Fix incorrect tag usage [Krzysztof]
>>
>>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 4884647a8a95..ca09367abb6c 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -13,6 +13,7 @@
>>   #include "pmk8350.dtsi"
>>
>>   #include "sc7280-chrome-common.dtsi"
>> +#include "sc7280-herobrine-lte-sku.dtsi"
> 
> I think you need to _remove_ the include from the "idp.dts" file now,
> right? Otherwise it gets included twice.

sry missed ^^, will fix it in the re-spin.

- Sibi