linux-kernel - Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2022 18:53:12 +1100
From:   Jacob Bai <jacob.bai.au@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to
 table.c/h

On Tue, Nov 08, 2022 at 04:23:32PM +0100, Greg KH wrote:
> On Sun, Nov 06, 2022 at 07:31:17PM +1100, Jacob Bai wrote:
> > Same as other rtlwifi drivers, use table.c/h.
> 
> You say what you do here, but not why.
> 
> Why rename the file?  What's wrong with the existing name?  It's not
> causing any problems, right?
> 
> thanks,
> 
> greg k-h
>
No, it's not causing problems. As we are trying to move this driver out
of staging folder, so I checked how current drivers naming
files/variables, turns out they all named those two files as table.c/h.
Maybe we can do the file renaming as the last step.

Jacob