linux-kernel - Re: [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211101659.j9z9jLHv-lkp@intel.com>
Date:   Thu, 10 Nov 2022 16:33:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     "zhiguo.niu" <zhiguo.niu@...soc.com>, jaegeuk@...nel.org,
        chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        niuzhiguo84@...il.com, zhiguo.niu@...soc.com
Subject: Re: [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

Hi zhiguo.niu",

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on linus/master v6.1-rc4 next-20221109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/zhiguo-niu/f2fs-fix-atgc-bug-on-issue-in-32bits-platform/20221108-153745
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link:    https://lore.kernel.org/r/1667889638-9106-1-git-send-email-zhiguo.niu%40unisoc.com
patch subject: [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform
config: arm-randconfig-c002-20221109
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/6181893cb29317549ddd9eac74282f75f2a73f66
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review zhiguo-niu/f2fs-fix-atgc-bug-on-issue-in-32bits-platform/20221108-153745
        git checkout 6181893cb29317549ddd9eac74282f75f2a73f66
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from fs/f2fs/gc.c:22:
>> fs/f2fs/gc.h:65:2: warning: field  within 'struct victim_entry' is less aligned than 'union victim_entry::(anonymous at fs/f2fs/gc.h:65:2)' and is usually due to 'struct victim_entry' being packed, which can lead to unaligned accesses [-Wunaligned-access]
           union {
           ^
   1 warning generated.


vim +65 fs/f2fs/gc.h

093749e296e29a Chao Yu    2020-08-04  62  
093749e296e29a Chao Yu    2020-08-04  63  struct victim_entry {
093749e296e29a Chao Yu    2020-08-04  64  	struct rb_node rb_node;		/* rb node located in rb-tree */
093749e296e29a Chao Yu    2020-08-04 @65  	union {
093749e296e29a Chao Yu    2020-08-04  66  		struct {
093749e296e29a Chao Yu    2020-08-04  67  			unsigned long long mtime;	/* mtime of section */
093749e296e29a Chao Yu    2020-08-04  68  			unsigned int segno;		/* segment No. */
093749e296e29a Chao Yu    2020-08-04  69  		};
093749e296e29a Chao Yu    2020-08-04  70  		struct victim_info vi;	/* victim info */
093749e296e29a Chao Yu    2020-08-04  71  	};
093749e296e29a Chao Yu    2020-08-04  72  	struct list_head list;
6181893cb29317 Zhiguo Niu 2022-11-08  73  } __packed;
093749e296e29a Chao Yu    2020-08-04  74  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (149347 bytes)