linux-kernel - Re: [PATCH] spi: mediatek: Fix DEVAPC Violation at KO Remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fc25cbd-6a4c-18e3-510e-a9cb1d394915@collabora.com>
Date:   Thu, 10 Nov 2022 10:01:04 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Zhichao Liu <zhichao.liu@...iatek.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        srv_heupstream@...iatek.com
Subject: Re: [PATCH] spi: mediatek: Fix DEVAPC Violation at KO Remove

Il 10/11/22 08:28, Zhichao Liu ha scritto:
> A DEVAPC violation occurs when removing the module
> due to accessing HW registers without base clock.
> To fix this bug, the correct method is:
> 1. Call the runtime resume function to enable the
>     clock;
> 2. Operate the registers to reset the HW;
> 3. Turn off the clocks and disable the device
>     RPM mechanism.
> 
> Signed-off-by: Zhichao Liu <zhichao.liu@...iatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>