linux-kernel - Re: [PATCH] mmc: atmel-mci: Convert to gpio descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d9b1e753-3bdd-4b8f-935e-718b0b590ace@app.fastmail.com>
Date:   Thu, 10 Nov 2022 10:02:25 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Andrew Lunn" <andrew@...n.ch>,
        "Balamanikandan Gunasundar" <balamanikandan.gunasundar@...rochip.com>
Cc:     "Ulf Hansson" <ulf.hansson@...aro.org>,
        linux-kernel@...r.kernel.org,
        linux-atm-general@...ts.sourceforge.net,
        "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        ludovic.desroches@...rochip.com, 3chas3@...il.com,
        Netdev <netdev@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mmc: atmel-mci: Convert to gpio descriptors

On Thu, Nov 10, 2022, at 09:05, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 18:16, Andrew Lunn wrote:
>> On Wed, Nov 09, 2022 at 10:08:45AM +0530, Balamanikandan Gunasundar wrote:
>>> Replace the legacy GPIO APIs with gpio descriptor consumer interface.
>>
>> I was wondering why you Cc: netdev and ATM. This clearly has nothing
>> to do with those lists.
>>
>> You well foul of
>>
>> M:	Chas Williams <3chas3@...il.com>
>> L:	linux-atm-general@...ts.sourceforge.net (moderated for non-subscribers)
>> L:	netdev@...r.kernel.org
>> S:	Maintained
>> W:	http://linux-atm.sourceforge.net
>> F:	drivers/atm/
>> F:	include/linux/atm*
>> F:	include/uapi/linux/atm*
>>
>> Maybe these atm* should be more specific so they don't match atmel :-)
>
> The uapi headers look unambiguous to me, for the three headers in
> include/linux/, only the atmdev.h is actually significant, while
> linux/atm.h and linux/atm_tcp.h could each be folded into the one
> C file that actually uses the contents.

Actually the situation for the linux/atmel*.h headers is similar:
most of them are only used in one file, and the linux/atmel-mci.h
contents should just be moved into drivers/mmc/host/atmel-mci.c
as part of Balamanikandan's patch, to allow further cleanups.

linux/atmel-isc-media.h similarly can go into its drivers as a
separate patch if desired.

The linux/atmel-ssc.h could ideally be cleaned up to get moved
into sound/soc/atmel/ along with drivers/misc/atmel-ssc.c.
The atmel-scc driver is technically also used by
sound/spi/at73c213.c, but that driver has been orphaned since
2014, with commit 2e591e7b3ac2 ("ARM: at91: remove
at91sam9261/at91sam9g10 legacy board support"), as nobody
ever added DT probing support to it.

      Arnd