linux-kernel - Re: [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6229b2ce6f49ccad25eed3ae00390b4553cf94a3.camel@mediatek.com>
Date:   Thu, 10 Nov 2022 10:34:14 +0000
From:   Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>,
        "wenst@...omium.org" <wenst@...omium.org>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change
 the max reg value to 2

Dear AngeloGioacchino Del,

Thank for your suggestion, looks very reasonable.
Fix in v2.

Best regards,
Yunfei Dong

On Wed, 2022-11-09 at 10:29 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/11/22 08:35, Yunfei Dong ha scritto:
> > Need to add racing control register base in device node for mt8195
> > support
> > inner racing mode. Changing the max reg value from 1 to 2.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
> > ---
> >   .../bindings/media/mediatek,vcodec-subdev-decoder.yaml          | 
> > 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index 794012853834..1697feb1f854 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -61,7 +61,7 @@ properties:
> >         - mediatek,mt8195-vcodec-dec
> >   
> >     reg:
> > -    maxItems: 1
> > +    maxItems: 2
> 
> What about doing, instead...
> 
> - description: VDEC_SYS register space
> - description: VDEC_RACING_CTRL register space
> 
> then, setting `minItems: 1` will make the racing_ctrl iospace
> optional :-)
> 
> Regards,
> Angelo
> 
>