linux-kernel - Re: [PATCH v5 2/2] staging: rtl8192e: replace macro defines with variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2zbV6xDUGPv8mVY@kadam>
Date:   Thu, 10 Nov 2022 14:07:03 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Jacob Bai <jacob.bai.au@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] staging: rtl8192e: replace macro defines with
 variables

On Thu, Nov 10, 2022 at 09:35:11PM +1100, Jacob Bai wrote:
> -u32 RTL8192E_PHY_REG_1T2R_ARRAY[RTL8192E_PHY_REG_1T2R_ARRAY_LEN] = {
> +u32 RTL8192E_PHY_REG_1T2R_ARRAY[] = {
>  	0x800, 0x00000000,
>  	0x804, 0x00000001,
>  	0x808, 0x0000fc00,
> @@ -158,8 +159,9 @@ u32 RTL8192E_PHY_REG_1T2R_ARRAY[RTL8192E_PHY_REG_1T2R_ARRAY_LEN] = {
>  	0xe18, 0x161a1a1a,
>  	0xe1c, 0x12121416,
>  };
> +u32 RTL8192E_PHY_REG_1T2R_ARRAY_LEN = ARRAY_SIZE(RTL8192E_PHY_REG_1T2R_ARRAY);

This patch is kind of a headache to review.  I have to go through and
count 148 array elements to ensure that the array hasn't changed size.

But the first patch renames all these arrays, so I first have go back
to patch #1 to find the original name.  It might be easier to do the
renames afterward.

Also the commit message should say something like "I have checked the
object code and there is no change at all" or "I have counted all these
array elements and there is no change to the size of the array."

regards,
dan carpenter