linux-kernel - Re: [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d8ad923707b1c6347d830088a410c31b794968c.camel@intel.com>
Date:   Thu, 10 Nov 2022 20:00:25 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups
 and fixes

On Wed, 2022-11-09 at 13:05 +0100, Rafael J. Wysocki wrote:
> Hi All,
> 
> This is a v2 of the series previously posted as
> 
> https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/
> 
> The first three patches in the series have not changed since then (I
> have
> considered moving the last patch, which is a fix, to the front, but
> that turns
> out to be a bit cumbersome and not really worth the effort).
> 
> This series of patches does some assorted ACPI-related cleanups to
> the CMOS RTC
> driver:
> - redundant static variable is dropped,
> - code duplication is reduced,
> - code is relocated so as to drop a few unnecessary forward
> declarations of
>   functions,
> - functions are renamed to avoid confusion,
> and fixes up an issue in the driver removal path.
> 
> 
> 

Reviewed-by: Zhang Rui <rui.zhang@...el.com>

And I have tested the patch series on a platform with both
use_acpi_alarm parameter set and cleared, the ACPI RTC fixed event
works as expected, for both runtime and suspend wakeups.

So
Tested-by: Zhang Rui <rui.zhang@...el.com>

thanks,
rui