linux-kernel - Re: [PATCH] eeprom: idt_89hpesx: Fix error handling in idt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221110121432.dtbuumgglj36v5kt@mobilestation>
Date:   Thu, 10 Nov 2022 15:14:32 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Yuan Can <yuancan@...wei.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        wsa+renesas@...g-engineering.com, benjamin.mugnier@...s.st.com,
        dmitry.torokhov@...il.com, cmo@...exis.com,
        u.kleine-koenig@...gutronix.de, error27@...il.com,
        justinstitt@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeprom: idt_89hpesx: Fix error handling in idt_init()

Hi Yuan,

On Thu, Nov 10, 2022 at 02:00:30AM +0000, Yuan Can wrote:
> A problem about idt_89hpesx create debugfs failed is triggered with the
> following log given:
> 
>  [ 4973.269647] debugfs: Directory 'idt_csr' with parent '/' already present!
> 
> The reason is that idt_init() returns i2c_add_driver() directly without
> checking its return value, if i2c_add_driver() failed, it returns without
> destroy the newly created debugfs, resulting the debugfs of idt_csr can
> never be created later.
> 
>  idt_init()
>    debugfs_create_dir() # create debugfs directory
>    i2c_add_driver()
>      driver_register()
>        bus_add_driver()
>          priv = kzalloc(...) # OOM happened
>    # return without destroy debugfs directory
> 
> Fix by removing debugfs when i2c_add_driver() returns error.
> 
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Yuan Can <yuancan@...wei.com>

Don't know what I was thinking back than. Thanks for fixing this.
Acked-by: Serge Semin <fancer.lancer@...il.com>

-Sergey

> ---
>  drivers/misc/eeprom/idt_89hpesx.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index bb3ed352b95f..367054e0ced4 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1566,12 +1566,20 @@ static struct i2c_driver idt_driver = {
>   */
>  static int __init idt_init(void)
>  {
> +	int ret;
> +
>  	/* Create Debugfs directory first */
>  	if (debugfs_initialized())
>  		csr_dbgdir = debugfs_create_dir("idt_csr", NULL);
>  
>  	/* Add new i2c-device driver */
> -	return i2c_add_driver(&idt_driver);
> +	ret = i2c_add_driver(&idt_driver);
> +	if (ret) {
> +		debugfs_remove_recursive(csr_dbgdir);
> +		return ret;
> +	}
> +
> +	return 0;
>  }
>  module_init(idt_init);
>  
> -- 
> 2.17.1
>