linux-kernel - Re: [PATCH linux-next] scsi: ibmvfc: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9717a9dd-45da-0d48-71a2-d2f64df8c7fc@csgroup.eu>
Date:   Thu, 10 Nov 2022 12:36:36 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     "yang.yang29@....com.cn" <yang.yang29@....com.cn>,
        "tyreld@...ux.ibm.com" <tyreld@...ux.ibm.com>
CC:     "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xu.panda@....com.cn" <xu.panda@....com.cn>
Subject: Re: [PATCH linux-next] scsi: ibmvfc: use sysfs_emit() to instead of
 scnprintf()

Le 10/11/2022 à 13:34, yang.yang29@....com.cn a écrit :
> [Vous ne recevez pas souvent de courriers de yang.yang29@....com.cn. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: Xu Panda <xu.panda@....com.cn>
> 
> Replace the open-code with sysfs_emit() to simplify the code.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> ---
>   drivers/scsi/ibmvscsi/ibmvfc.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 1a0c0b7289d2..c412752ea140 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -3411,7 +3411,7 @@ static ssize_t ibmvfc_show_host_partition_name(struct device *dev,
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> 
> -       return snprintf(buf, PAGE_SIZE, "%s\n",
> +       return sysfs_emit(buf, "%s\n",
>                          vhost->login_buf->resp.partition_name);

Could it fit on a single line now ?

>   }
> 
> @@ -3421,7 +3421,7 @@ static ssize_t ibmvfc_show_host_device_name(struct device *dev,
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> 
> -       return snprintf(buf, PAGE_SIZE, "%s\n",
> +       return sysfs_emit(buf, "%s\n",
>                          vhost->login_buf->resp.device_name);

Could it fit on a single line now ?

>   }
> 
> @@ -3431,7 +3431,7 @@ static ssize_t ibmvfc_show_host_loc_code(struct device *dev,
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> 
> -       return snprintf(buf, PAGE_SIZE, "%s\n",
> +       return sysfs_emit(buf, "%s\n",
>                          vhost->login_buf->resp.port_loc_code);

Could it fit on a single line now ?

>   }
> 
> @@ -3441,7 +3441,7 @@ static ssize_t ibmvfc_show_host_drc_name(struct device *dev,
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> 
> -       return snprintf(buf, PAGE_SIZE, "%s\n",
> +       return sysfs_emit(buf, "%s\n",
>                          vhost->login_buf->resp.drc_name);

Could it fit on a single line now ?

>   }
> 
> @@ -3450,7 +3450,7 @@ static ssize_t ibmvfc_show_host_npiv_version(struct device *dev,
>   {
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> -       return snprintf(buf, PAGE_SIZE, "%d\n", be32_to_cpu(vhost->login_buf->resp.version));
> +       return sysfs_emit(buf, "%d\n", be32_to_cpu(vhost->login_buf->resp.version));
>   }
> 
>   static ssize_t ibmvfc_show_host_capabilities(struct device *dev,
> @@ -3458,7 +3458,7 @@ static ssize_t ibmvfc_show_host_capabilities(struct device *dev,
>   {
>          struct Scsi_Host *shost = class_to_shost(dev);
>          struct ibmvfc_host *vhost = shost_priv(shost);
> -       return snprintf(buf, PAGE_SIZE, "%llx\n", be64_to_cpu(vhost->login_buf->resp.capabilities));
> +       return sysfs_emit(buf, "%llx\n", be64_to_cpu(vhost->login_buf->resp.capabilities));
>   }
> 
>   /**
> @@ -3479,7 +3479,7 @@ static ssize_t ibmvfc_show_log_level(struct device *dev,
>          int len;
> 
>          spin_lock_irqsave(shost->host_lock, flags);
> -       len = snprintf(buf, PAGE_SIZE, "%d\n", vhost->log_level);
> +       len = sysfs_emit(buf, "%d\n", vhost->log_level);
>          spin_unlock_irqrestore(shost->host_lock, flags);
>          return len;
>   }
> @@ -3517,7 +3517,7 @@ static ssize_t ibmvfc_show_scsi_channels(struct device *dev,
>          int len;
> 
>          spin_lock_irqsave(shost->host_lock, flags);
> -       len = snprintf(buf, PAGE_SIZE, "%d\n", vhost->client_scsi_channels);
> +       len = sysfs_emit(buf, "%d\n", vhost->client_scsi_channels);
>          spin_unlock_irqrestore(shost->host_lock, flags);
>          return len;
>   }
> --
> 2.15.2