linux-kernel - Re: [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b43a03b2-ca53-fbdd-b4d0-03e424638468@linaro.org>
Date:   Thu, 10 Nov 2022 13:54:54 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sam Protsenko <semen.protsenko@...aro.org>,
        Vivek Yadav <vivek.2311@...sung.com>
Cc:     rcsekar@...sung.com, krzysztof.kozlowski+dt@...aro.org,
        wg@...ndegger.com, mkl@...gutronix.de, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        pankaj.dubey@...sung.com, ravi.patel@...sung.com,
        alim.akhtar@...sung.com, linux-fsd@...la.com, robh+dt@...nel.org,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        aswani.reddy@...sung.com, sriranjani.p@...sung.com
Subject: Re: [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node

On 09/11/2022 12:17, Sam Protsenko wrote:
> Hi Vivek,
> 
> On Wed, 9 Nov 2022 at 11:54, Vivek Yadav <vivek.2311@...sung.com> wrote:
>>
>> From: Sriranjani P <sriranjani.p@...sung.com>
>>
>> Add SYSREG controller device node, which is available in PERIC and FSYS0
>> block of FSD SoC.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
>> Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey@...sung.com>
>> Cc: devicetree@...r.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
>> ---
>>  arch/arm64/boot/dts/tesla/fsd.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
>> index f35bc5a288c2..3d8ebbfc27f4 100644
>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>> @@ -518,6 +518,16 @@
>>                                 "dout_cmu_fsys1_shared0div4";
>>                 };
>>
>> +               sysreg_peric: system-controller@...30000 {
>> +                       compatible = "tesla,sysreg_peric", "syscon";
>> +                       reg = <0x0 0x14030000 0x0 0x1000>;
> 
> Probably not related to this particular patch, but does the "reg"
> really have to have those extra 0x0s? Why it can't be just:
> 
>     reg = <0x14030000 0x1000>;
> 
> That comment applies to the whole dts/dtsi. Looks like #address-cells
> or #size-cells are bigger than they should be, or I missing something?

Yes, it looks like intention was to support some 64-bit addresses (maybe
as convention for arm64?) but none of upstreamed are above 32 bit range.
I don't have the manual/datasheet to judge whether any other
(non-upstreamed) nodes need 64bit addresses.

Best regards,
Krzysztof