linux-kernel - Re: [PATCH v3] net/mlx5e: Use kzalloc() in mlx5e_accel_fs_tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <939ca9bb-0207-2b14-8d44-09c47deb72c6@gmail.com>
Date:   Thu, 10 Nov 2022 17:01:31 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, borisp@...dia.com,
        saeedm@...dia.com, leon@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        lkayal@...dia.com, tariqt@...dia.com
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net/mlx5e: Use kzalloc() in
 mlx5e_accel_fs_tcp_create()



On 11/10/2022 3:43 PM, YueHaibing wrote:
> 'accel_tcp' is allocted by kvzalloc() now, which is a small chunk.
> Use kzalloc() directly instead of kvzalloc(), fix the mismatch free.
> 
> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v3: use kzalloc() instead of kvzalloc()
> v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> index 285d32d2fd08..88a5aed9d678 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> @@ -377,7 +377,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
>   	if (!MLX5_CAP_FLOWTABLE_NIC_RX(mlx5e_fs_get_mdev(fs), ft_field_support.outer_ip_version))
>   		return -EOPNOTSUPP;
>   
> -	accel_tcp = kvzalloc(sizeof(*accel_tcp), GFP_KERNEL);
> +	accel_tcp = kzalloc(sizeof(*accel_tcp), GFP_KERNEL);
>   	if (!accel_tcp)
>   		return -ENOMEM;
>   	mlx5e_fs_set_accel_tcp(fs, accel_tcp);

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks.