linux-kernel - [PATCH 1/3] mailbox: pcc: rename platform interrupt bit macro name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2022 09:50:32 +0800
From:   Huisong Li <lihuisong@...wei.com>
To:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <rafael@...nel.org>, <sudeep.holla@....com>,
        <rafael.j.wysocki@...el.com>, <wanghuiqiang@...wei.com>,
        <zhangzekun11@...wei.com>, <wangxiongfeng2@...wei.com>,
        <tanxiaofei@...wei.com>, <guohanjun@...wei.com>,
        <xiexiuqi@...wei.com>, <wangkefeng.wang@...wei.com>,
        <huangdaode@...wei.com>, <lihuisong@...wei.com>
Subject: [PATCH 1/3] mailbox: pcc: rename platform interrupt bit macro name

Currently, the name of platform interrupt bit macro, ACPI_PCCT_DOORBELL,
is not very appropriate. The doorbell is generally considered as an action
when send mailbox data. Actually, the macro value comes from Platform
Interrupt in Platform Communications Channel Global Flags. If the bit is
'1', it means that the platform is capable of generating an interrupt to
indicate completion of a command.

Signed-off-by: Huisong Li <lihuisong@...wei.com>
---
 drivers/mailbox/pcc.c | 2 +-
 include/acpi/actbl2.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index 3c2bc0ca454c..7cee37dd3b73 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -665,7 +665,7 @@ static int pcc_mbox_probe(struct platform_device *pdev)
 		(unsigned long) pcct_tbl + sizeof(struct acpi_table_pcct));
 
 	acpi_pcct_tbl = (struct acpi_table_pcct *) pcct_tbl;
-	if (acpi_pcct_tbl->flags & ACPI_PCCT_DOORBELL)
+	if (acpi_pcct_tbl->flags & BIT(ACPI_PCCT_FLAGS_PLAT_INTERRUPT_B))
 		pcc_mbox_ctrl->txdone_irq = true;
 
 	for (i = 0; i < count; i++) {
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index 655102bc6d14..3840507fdc79 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -1810,7 +1810,7 @@ struct acpi_table_pcct {
 
 /* Values for Flags field above */
 
-#define ACPI_PCCT_DOORBELL              1
+#define ACPI_PCCT_FLAGS_PLAT_INTERRUPT_B              1
 
 /* Values for subtable type in struct acpi_subtable_header */
 
-- 
2.22.0