linux-kernel - Re: [PATCH RFC] maple_tree: should get pivots boundary by type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221110161239.crapogyt7owdqd7y@revolver>
Date:   Thu, 10 Nov 2022 16:14:31 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Wei Yang <richard.weiyang@...il.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] maple_tree: should get pivots boundary by type

* Wei Yang <richard.weiyang@...il.com> [221110 02:25]:
> If my understanding is correct, we should get pivots boundary by type.
> 

Thank you, yes - you are correct.  This is a bug, and should have:

Fixes: 54a611b60590 (Maple Tree: add new data structure)

Please fix your commit message and add the fixes line and resend.

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
> CC: Liam R. Howlett <Liam.Howlett@...cle.com>
> 
> ---
> * kernel build looks good
> ---
>  lib/maple_tree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 73e2e6434e2f..2123d1930a9b 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn,
>  				 unsigned char piv)
>  {
>  	struct maple_node *node = mte_to_node(mn);
> +	enum maple_type type = mte_node_type(mn);
>  
> -	if (piv >= mt_pivots[piv]) {
> +	if (piv >= mt_pivots[type]) {
>  		WARN_ON(1);
>  		return 0;
>  	}
> -	switch (mte_node_type(mn)) {
> +	switch (type) {
>  	case maple_arange_64:
>  		return node->ma64.pivot[piv];
>  	case maple_range_64:
> -- 
> 2.33.1
>