lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Nov 2022 08:29:49 -0800 From: coverity-bot <keescook@...omium.org> To: Benjamin Mugnier <benjamin.mugnier@...s.st.com> Cc: linux-kernel@...r.kernel.org, Sakari Ailus <sakari.ailus@...ux.intel.com>, Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>, Shawn Tu <shawnx.tu@...el.com>, linux-media@...r.kernel.org, Sylvain Petinot <sylvain.petinot@...s.st.com>, Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab <mchehab@...nel.org>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, linux-next@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Coverity: vgxy61_configure(): Control flow issues Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Thu Oct 27 14:37:38 2022 +0300 153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor") Coverity reported the following: *** CID 1527253: Control flow issues (NO_EFFECT) drivers/media/i2c/st-vgxy61.c:1579 in vgxy61_configure() 1573 /* Frequency to data rate is 1:1 ratio for MIPI */ 1574 sensor->data_rate_in_mbps = sensor_freq; 1575 /* Video timing ISP path (pixel clock) requires 804/5 mhz = 160 mhz */ 1576 sensor->pclk = sensor_freq / 5; 1577 1578 line_length = vgxy61_read_reg(sensor, VGXY61_REG_LINE_LENGTH); vvv CID 1527253: Control flow issues (NO_EFFECT) vvv This less-than-zero comparison of an unsigned value is never true. "line_length < 0". 1579 if (line_length < 0) 1580 return line_length; 1581 sensor->line_length = line_length; 1582 vgxy61_write_reg(sensor, VGXY61_REG_EXT_CLOCK, sensor->clk_freq, &ret); 1583 vgxy61_write_reg(sensor, VGXY61_REG_CLK_PLL_PREDIV, prediv, &ret); 1584 vgxy61_write_reg(sensor, VGXY61_REG_CLK_SYS_PLL_MULT, mult, &ret); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@...omium.org> Addresses-Coverity-ID: 1527253 ("Control flow issues") Fixes: 153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor") Thanks for your attention! -- Coverity-bot
Powered by blists - more mailing lists