linux-kernel - Coverity: tc358746_apply_pll_config(): Control flow issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202211100830.5E3EE2678@keescook>
Date:   Thu, 10 Nov 2022 08:30:35 -0800
From:   coverity-bot <keescook@...omium.org>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>,
        Shawn Tu <shawnx.tu@...el.com>, linux-media@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-next@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Coverity: tc358746_apply_pll_config(): Control flow issues

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Thu Oct 27 14:48:40 2022 +0300
    80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")

Coverity reported the following:

*** CID 1527252:  Control flow issues  (DEADCODE)
drivers/media/i2c/tc358746.c:411 in tc358746_apply_pll_config()
405     		return err;
406
407     	val = PLL_FRS(ilog2(post)) | RESETB | PLL_EN;
408     	mask = PLL_FRS_MASK | RESETB | PLL_EN;
409     	tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val);
410     	if (err)
vvv     CID 1527252:  Control flow issues  (DEADCODE)
vvv     Execution cannot reach this statement: "return err;".
411     		return err;
412
413     	fsleep(1000);
414
415     	return tc358746_set_bits(tc358746, PLLCTL1_REG, CKEN);
416     }

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
Addresses-Coverity-ID: 1527252 ("Control flow issues")
Fixes: 80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")

Thanks for your attention!

-- 
Coverity-bot