linux-kernel - Re: [PATCH] pwm: tegra: Fix 32 bit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 15:30:10 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        Steven Price <steven.price@....com>
Cc:     linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH] pwm: tegra: Fix 32 bit build

On Thu, 10 Nov 2022 11:45:48 +0000, Steven Price wrote:
> The value of NSEC_PER_SEC << PWM_DUTY_WIDTH doesn't fix within a 32 bit
> integer causing a build warning/error (and the value truncated):
> 
>   drivers/pwm/pwm-tegra.c: In function ‘tegra_pwm_config’:
>   drivers/pwm/pwm-tegra.c:148:53: error: result of ‘1000000000 << 8’ requires 39 bits to represent, but ‘long int’ only has 32 bits [-Werror=shift-overflow=]
>     148 |   required_clk_rate = DIV_ROUND_UP_ULL(NSEC_PER_SEC << PWM_DUTY_WIDTH,
>         |                                                     ^~
> 
> [...]

Applied, thanks!

[1/1] pwm: tegra: Fix 32 bit build
      commit: dd1f1da4ada5d8ac774c2ebe97230637820b3323

Best regards,
-- 
Thierry Reding <thierry.reding@...il.com>