linux-kernel - Re: [PATCH v2 1/2] device property: Get rid of __PROPERTY_ENTRY_ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 22:31:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 1/2] device property: Get rid of
 __PROPERTY_ENTRY_ARRAY_EL*SIZE*()

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20221111]
[also build test ERROR on v6.1-rc4]
[cannot apply to linus/master sailus-media-tree/streams v6.1-rc4 v6.1-rc3 v6.1-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Get-rid-of-__PROPERTY_ENTRY_ARRAY_EL-SIZE/20221111-201519
patch link:    https://lore.kernel.org/r/20221111121518.44145-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v2 1/2] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*()
config: sh-randconfig-r002-20221111
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5e456016551f46fb1ac6d6e105c5f643ec45dfd5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/device-property-Get-rid-of-__PROPERTY_ENTRY_ARRAY_EL-SIZE/20221111-201519
        git checkout 5e456016551f46fb1ac6d6e105c5f643ec45dfd5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/base/test/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/base/test/property-entry-test.c:7:
   drivers/base/test/property-entry-test.c: In function 'pe_test_reference':
>> include/linux/property.h:337:17: error: 'DEV_PROP__Type_' undeclared (first use in this function); did you mean 'DEV_PROP_STRING'?
     337 |         .type = DEV_PROP_##_Type_,                                      \
         |                 ^~~~~~~~~
   include/linux/property.h:352:9: note: in expansion of macro 'PROPERTY_ENTRY_REF_ARRAY_LEN'
     352 |         PROPERTY_ENTRY_REF_ARRAY_LEN(_name_, _val_, ARRAY_SIZE(_val_))
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/test/property-entry-test.c:422:17: note: in expansion of macro 'PROPERTY_ENTRY_REF_ARRAY'
     422 |                 PROPERTY_ENTRY_REF_ARRAY("ref-3", refs),
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/property.h:337:17: note: each undeclared identifier is reported only once for each function it appears in
     337 |         .type = DEV_PROP_##_Type_,                                      \
         |                 ^~~~~~~~~
   include/linux/property.h:352:9: note: in expansion of macro 'PROPERTY_ENTRY_REF_ARRAY_LEN'
     352 |         PROPERTY_ENTRY_REF_ARRAY_LEN(_name_, _val_, ARRAY_SIZE(_val_))
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/test/property-entry-test.c:422:17: note: in expansion of macro 'PROPERTY_ENTRY_REF_ARRAY'
     422 |                 PROPERTY_ENTRY_REF_ARRAY("ref-3", refs),
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~


vim +337 include/linux/property.h

   322	
   323	#define PROPERTY_ENTRY_U8_ARRAY_LEN(_name_, _val_, _len_)		\
   324		__PROPERTY_ENTRY_ARRAY_LEN(_name_, u8_data, U8, _val_, _len_)
   325	#define PROPERTY_ENTRY_U16_ARRAY_LEN(_name_, _val_, _len_)		\
   326		__PROPERTY_ENTRY_ARRAY_LEN(_name_, u16_data, U16, _val_, _len_)
   327	#define PROPERTY_ENTRY_U32_ARRAY_LEN(_name_, _val_, _len_)		\
   328		__PROPERTY_ENTRY_ARRAY_LEN(_name_, u32_data, U32, _val_, _len_)
   329	#define PROPERTY_ENTRY_U64_ARRAY_LEN(_name_, _val_, _len_)		\
   330		__PROPERTY_ENTRY_ARRAY_LEN(_name_, u64_data, U64, _val_, _len_)
   331	#define PROPERTY_ENTRY_STRING_ARRAY_LEN(_name_, _val_, _len_)		\
   332		__PROPERTY_ENTRY_ARRAY_LEN(_name_, str, STRING, _val_, _len_)
   333	#define PROPERTY_ENTRY_REF_ARRAY_LEN(_name_, _val_, _len_)		\
   334	(struct property_entry) {						\
   335		.name = _name_,							\
   336		.length = (_len_) * sizeof(struct software_node_ref_args),	\
 > 337		.type = DEV_PROP_##_Type_,					\
   338		{ .pointer = _val_ },						\
   339	}
   340	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (107060 bytes)