linux-kernel - Re: [PATCH v2] MIPS: jump_label: Fix compat branch range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 16:04:24 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        ardb@...nel.org, rostedt@...dmis.org, stable@...r.kernel.org,
        Philippe Mathieu-Daudé <philmd@...aro.org>
Subject: Re: [PATCH v2] MIPS: jump_label: Fix compat branch range check

On Thu, Nov 03, 2022 at 03:10:53PM +0000, Jiaxun Yang wrote:
> Cast upper bound of branch range to long to do signed compare,
> avoid negative offset trigger this warning.
> 
> Fixes: 9b6584e35f40 ("MIPS: jump_label: Use compact branches for >= r6")
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> Cc: stable@...r.kernel.org
> Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>
> ---
> v2: Fix typo, collect review tags.
> ---
>  arch/mips/kernel/jump_label.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/jump_label.c b/arch/mips/kernel/jump_label.c
> index 71a882c8c6eb..f7978d50a2ba 100644
> --- a/arch/mips/kernel/jump_label.c
> +++ b/arch/mips/kernel/jump_label.c
> @@ -56,7 +56,7 @@ void arch_jump_label_transform(struct jump_entry *e,
>  			 * The branch offset must fit in the instruction's 26
>  			 * bit field.
>  			 */
> -			WARN_ON((offset >= BIT(25)) ||
> +			WARN_ON((offset >= (long)BIT(25)) ||
>  				(offset < -(long)BIT(25)));
>  
>  			insn.j_format.opcode = bc6_op;
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]