linux-kernel - Re: [PATCH v2 1/2] ASoC: dt-bindings: qcom,wsa883x: Use correct SD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 16:42:13 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: qcom,wsa883x: Use correct SD_N
 polarity



On 10/11/2022 13:35, Krzysztof Kozlowski wrote:
> Use correct polarity in example and powerdown-gpios description.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> 
> Changes since v1:
> 1. New patch.
> ---
>   Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> index 6113f65f2990..99f9c10bbc83 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml
> @@ -23,7 +23,7 @@ properties:
>       maxItems: 1
>   
>     powerdown-gpios:
> -    description: GPIO spec for Powerdown/Shutdown line to use
> +    description: GPIO spec for Powerdown/Shutdown line to use (pin SD_N)
>       maxItems: 1
>   
>     vdd-supply:
> @@ -47,6 +47,8 @@ additionalProperties: false
>   
>   examples:
>     - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
>       soundwire-controller@...0000 {
>           #address-cells = <2>;
>           #size-cells = <0>;
> @@ -55,7 +57,7 @@ examples:
>           speaker@0,1 {
>               compatible = "sdw10217020200";
>               reg = <0 1>;
> -            powerdown-gpios = <&tlmm 1 0>;
> +            powerdown-gpios = <&tlmm 1 GPIO_ACTIVE_LOW>;
>               vdd-supply = <&vreg_s10b_1p8>;
>               #thermal-sensor-cells = <0>;
>               #sound-dai-cells = <0>;
> @@ -64,7 +66,7 @@ examples:
>           speaker@0,2 {
>               compatible = "sdw10217020200";
>               reg = <0 2>;
> -            powerdown-gpios = <&tlmm 89 0>;
> +            powerdown-gpios = <&tlmm 89 GPIO_ACTIVE_LOW>;
>               vdd-supply = <&vreg_s10b_1p8>;
>               #thermal-sensor-cells = <0>;
>               #sound-dai-cells = <0>;