[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2022 10:08:04 -0800
From: Stanislav Fomichev <sdf@...gle.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Rong Tao <rtoax@...mail.com>, ast@...nel.org,
Rong Tao <rongtao@...tc.cn>, kernel test robot <lkp@...el.com>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>,
Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>,
Shuah Khan <shuah@...nel.org>,
Kumar Kartikeya Dwivedi <memxor@...il.com>,
Daniel Xu <dxu@...uu.xyz>,
"open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)"
<bpf@...r.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix error undeclared identifier 'NF_NAT_MANIP_SRC'
On Fri, Nov 11, 2022 at 9:54 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> > On 11/11, Rong Tao wrote:
> > > From: Rong Tao <rongtao@...tc.cn>
> >
> > > commit 472caa69183f("netfilter: nat: un-export nf_nat_used_tuple")
> > > introduce NF_NAT_MANIP_SRC/DST enum in include/net/netfilter/nf_nat.h,
> > > and commit b06b45e82b59("selftests/bpf: add tests for bpf_ct_set_nat_info
> > > kfunc") use NF_NAT_MANIP_SRC/DST in test_bpf_nf.c. We copy enum
> > > nf_nat_manip_type to test_bpf_nf.c fix this error.
> >
> > > How to reproduce the error:
> >
> > > $ make -C tools/testing/selftests/bpf/
> > > ...
> > > CLNG-BPF [test_maps] test_bpf_nf.bpf.o
> > > error: use of undeclared identifier 'NF_NAT_MANIP_SRC'
> > > bpf_ct_set_nat_info(ct, &saddr, sport, NF_NAT_MANIP_SRC);
> > > ^
> > > error: use of undeclared identifier 'NF_NAT_MANIP_DST'
> > > bpf_ct_set_nat_info(ct, &daddr, dport, NF_NAT_MANIP_DST);
> > > ^
> > > 2 errors generated.
> >
> > $ grep NF_NAT_MANIP_SRC
> > ./tools/testing/selftests/bpf/tools/include/vmlinux.h
> > NF_NAT_MANIP_SRC = 0,
> >
> > Doesn't look like your kernel config compiles netfilter nat modules?
>
> yes, in bpf kself-test config (tools/testing/selftests/bpf/config) nf_nat
> is compiled as built-in. This issue occurs just if it is compiled as module.
Right, but if we unconditionally define this enum, I think you'll
break the case where it's compiled as a built-in?
Since at least in my vmlinux.h I have all the defines and this test
includes vmlinux.h...
> Regards,
> Lorenzo
>
> >
> > > Link: https://lore.kernel.org/lkml/202210280447.STsT1gvq-lkp@intel.com/
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Signed-off-by: Rong Tao <rongtao@...tc.cn>
> > > ---
> > > tools/testing/selftests/bpf/progs/test_bpf_nf.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> >
> > > diff --git a/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > > b/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > > index 227e85e85dda..307ca166ff34 100644
> > > --- a/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > > +++ b/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > > @@ -3,6 +3,11 @@
> > > #include <bpf/bpf_helpers.h>
> > > #include <bpf/bpf_endian.h>
> >
> > > +enum nf_nat_manip_type {
> > > + NF_NAT_MANIP_SRC,
> > > + NF_NAT_MANIP_DST
> > > +};
> > > +
> > > #define EAFNOSUPPORT 97
> > > #define EPROTO 71
> > > #define ENONET 64
> > > --
> > > 2.31.1
> >
Powered by blists - more mailing lists