[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2022 14:35:36 -0500
From: Detlev Casanova <detlev.casanova@...labora.com>
To: Shawn Guo <shawnguo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabre: Add mmc aliases
On Thursday, November 10, 2022 9:52:32 P.M. EST Shawn Guo wrote:
> On Fri, Oct 28, 2022 at 10:18:11AM -0400, Detlev Casanova wrote:
> > If not specified, the mmc0 and mmc1 devices will be the devices
> > mmc@...0000 and mmc@...4000, which are in disabled state on the iMX.6
> > Sabrelite devices.
> >
> > The actual SD card reader devices are the ones at mmc@...8000 and
> > mmc@...c000.
> >
> > Set aliases to use the correct mmc devices order.
>
> Is this something never worked or a regression? For the latter, we may
> need a Fixes tag?
These were apparently never set in the kernel device-tree and added manually
in u-boot when dts are synced.
Because most distributions use UUIDs in fstab, it is not a big problem in
Linux, just that the SD card is called /dev/mmcblk2. I would say that this has
always been an issue in Linux.
> Shawn
>
> > Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> > ---
> >
> > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi index
> > 22f8e2783cdf..12573e1f917c 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > @@ -14,6 +14,11 @@ chosen {
> >
> > stdout-path = &uart2;
> >
> > };
> >
> > + aliases {
> > + mmc0 = &usdhc3;
> > + mmc1 = &usdhc4;
> > + };
> > +
> >
> > memory@...00000 {
> >
> > device_type = "memory";
> > reg = <0x10000000 0x40000000>;
Powered by blists - more mailing lists