linux-kernel - Re: [PATCH v12 5/6] media: microchip: microchip-isc: move media_pipeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Nov 2022 07:07:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        hverkuil-cisco@...all.nl, jacopo@...ndi.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev,
        Eugen Hristev <eugen.hristev@...rochip.com>
Subject: Re: [PATCH v12 5/6] media: microchip: microchip-isc: move
 media_pipeline_* to (un)prepare cb

Hi Eugen,

I love your patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on soc/for-next linus/master sailus-media-tree/streams v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/media-atmel-atmel-isc-driver-redesign/20221107-222554
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221107141818.104937-6-eugen.hristev%40microchip.com
patch subject: [PATCH v12 5/6] media: microchip: microchip-isc: move media_pipeline_* to (un)prepare cb
config: ia64-allmodconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/03b56a6f5e4cea93bf3bb2072be7a1d2ca8c5449
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eugen-Hristev/media-atmel-atmel-isc-driver-redesign/20221107-222554
        git checkout 03b56a6f5e4cea93bf3bb2072be7a1d2ca8c5449
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/media/platform/microchip/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/media/platform/microchip/microchip-isc-base.c:480:10: error: 'const struct vb2_ops' has no member named 'prepare_streaming'; did you mean 'start_streaming'?
     480 |         .prepare_streaming      = isc_prepare_streaming,
         |          ^~~~~~~~~~~~~~~~~
         |          start_streaming
>> drivers/media/platform/microchip/microchip-isc-base.c:480:35: error: initialization of 'void (*)(struct vb2_buffer *)' from incompatible pointer type 'int (*)(struct vb2_queue *)' [-Werror=incompatible-pointer-types]
     480 |         .prepare_streaming      = isc_prepare_streaming,
         |                                   ^~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/microchip/microchip-isc-base.c:480:35: note: (near initialization for 'isc_vb2_ops.buf_request_complete')
>> drivers/media/platform/microchip/microchip-isc-base.c:481:10: error: 'const struct vb2_ops' has no member named 'unprepare_streaming'; did you mean 'start_streaming'?
     481 |         .unprepare_streaming    = isc_unprepare_streaming,
         |          ^~~~~~~~~~~~~~~~~~~
         |          start_streaming
   drivers/media/platform/microchip/microchip-isc-base.c:481:35: warning: excess elements in struct initializer
     481 |         .unprepare_streaming    = isc_unprepare_streaming,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/microchip/microchip-isc-base.c:481:35: note: (near initialization for 'isc_vb2_ops')
   cc1: some warnings being treated as errors


vim +480 drivers/media/platform/microchip/microchip-isc-base.c

   471	
   472	static const struct vb2_ops isc_vb2_ops = {
   473		.queue_setup		= isc_queue_setup,
   474		.wait_prepare		= vb2_ops_wait_prepare,
   475		.wait_finish		= vb2_ops_wait_finish,
   476		.buf_prepare		= isc_buffer_prepare,
   477		.start_streaming	= isc_start_streaming,
   478		.stop_streaming		= isc_stop_streaming,
   479		.buf_queue		= isc_buffer_queue,
 > 480		.prepare_streaming	= isc_prepare_streaming,
 > 481		.unprepare_streaming	= isc_unprepare_streaming,
   482	};
   483	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (286928 bytes)