[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 11 Nov 2022 09:41:25 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc: Bard Liao <yung-chuan.liao@...ux.intel.com>,
stable@...r.kernel.org, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, bard.liao@...el.com
Subject: Re: [PATCH] soundwire: intel: Initialize clock stop timeout
On 09-11-22, 10:05, Pierre-Louis Bossart wrote:
>
>
> On 10/28/22 06:28, Vinod Koul wrote:
> > On 20-10-22, 09:56, Bard Liao wrote:
> >> From: Sjoerd Simons <sjoerd@...labora.com>
> >>
> >> The bus->clk_stop_timeout member is only initialized to a non-zero value
> >> during the codec driver probe. This can lead to corner cases where this
> >> value remains pegged at zero when the bus suspends, which results in an
> >> endless loop in sdw_bus_wait_for_clk_prep_deprep().
> >>
> >> Corner cases include configurations with no codecs described in the
> >> firmware, or delays in probing codec drivers.
> >>
> >> Initializing the default timeout to the smallest non-zero value avoid this
> >> problem and allows for the existing logic to be preserved: the
> >> bus->clk_stop_timeout is set as the maximum required by all codecs
> >> connected on the bus.
> >
> > Applied to fixes, thanks
>
> Thanks Vinod, was this sent to Greg/Linus? the last pull request I see
> was for 6.1-rc1.
> Arch Linux cherry-picked this patch but other distros did not, so quite
> a few users are left with no audio card.
https://git.kernel.org/torvalds/c/f014699cca9a9a28fbdc06a9225b54562154fc20
--
~Vinod
Powered by blists - more mailing lists