linux-kernel - RE: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 08:50:38 +0530
From:   "Aakarsh Jain" <aakarsh.jain@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
        <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <ezequiel@...guardiasur.com.ar>, <jernej.skrabec@...il.com>,
        <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <alim.akhtar@...sung.com>, <aswani.reddy@...sung.com>,
        <pankaj.dubey@...sung.com>, <smitha.t@...sung.com>
Subject: RE: [Patch v2 1/3] arm: exynos: Add new compatible string for
 Exynos3250 SoC.



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 09 November 2022 14:43
> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> david.plowman@...pberrypi.com; mark.rutland@....com;
> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> pankaj.dubey@...sung.com; smitha.t@...sung.com
> Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for
> Exynos3250 SoC.
> 
> On 09/11/2022 04:55, Aakarsh Jain wrote:
> > Since,MFC v7 support was added for Exynos5420 and Exynos
> > 3250 SoC with same compatible string "samsung,mfc-v7".As both SoCs
> > having different hardware properties and having same compatible string
> > for both SoCs doesn't seems to be correct.
> > New compatible is added for Exynos3250 SOC which will differentiate
> > the node properties for both SoCs which support MFC v7.
> >
> > Reviewed-by: Tommaso Merciai
> <tommaso.merciai@...rulasolutions.com>
> > Suggested-by: Alim Akhtar <alim.akhtar@...sung.com>
> > Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
> > ---
> >  Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> 
> Beside my previous comment, please include changelog. This is v2, right?
> 
Yes this is v2.
I have sent v3 along with cover letter.

> You should consider joining something like:
> https://protect2.fireeye.com/v1/url?k=bf47b121-dfa52c7c-bf463a6e-
> 000babd9f1ba-202e284cd3057a5d&q=1&e=009abfcf-7d3c-433c-8eea-
> 0f9d92caf6cc&u=https%3A%2F%2Fwww.linaro.org%2Fevents%2Fmember-
> training-upstream-kernel-development%2F
> 
> Best regards,
> Krzysztof

Thanks for review.