linux-kernel - Re: [6.1.0-rc4-next-20221109] Boot time warning kernel/module/main.c:852

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 10:25:00 +0530
From:   Sachin Sant <sachinp@...ux.ibm.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     linux-scsi@...r.kernel.org,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [6.1.0-rc4-next-20221109] Boot time warning
 kernel/module/main.c:852

>> [ 8.809079] [c000000007c37e10] [c00000000000cffc] ret_from_kernel_thread+0x5c/0x64
>> [ 8.809086] Instruction dump:
>> [ 8.809090] f821ffc1 41820034 395e03c0 7c0004ac 7d205028 2c090001 3929ffff 41c00010
>> [ 8.809101] 7d20512d
>> [ 8.809101] sd 1:0:0:1: [sdc] Preferred minimum I/O size 32768 bytes
>> [ 8.809102] 40c2ffec 7c0004ac 79290fe2 <0b090000> 60000000 38210040 ebc1fff0
>> [ 8.809115] ---[ end trace 0000000000000000 ]—
>> -next-20221108 was good. Git bisect points to following
>> commit 0b25e17e9018a0ea68a9f0b4787672e8c68fa8d5
>> Date:   Mon Oct 31 15:47:25 2022 -0700
>>     scsi: alua: Move a scsi_device_put() call out of alua_check_vpd()
>> Reverting this patch gets rid of the warning.
> 
> Hi Sachin,
> 
> Thanks for the detailed report. Does the patch below help?
> 

Yup, thanks. With this change applied I do not see the warning.

- Sachin

> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 693cd827e138..d2cf15338724 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -1025,7 +1025,7 @@ static bool __must_check alua_rtpg_queue(struct alua_port_group *pg,
> kref_put(&pg->kref, release_port_group);
> }
> 
> - return true;
> + return sdev != NULL;
> }
> 
> /*
>