linux-kernel - Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 13:46:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shenwei Wang <shenwei.wang@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
        Shenwei Wang <shenwei.wang@....com>
Subject: Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool statistics

Hi Shenwei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on next-20221110]
[cannot apply to net/master linus/master v6.1-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shenwei-Wang/net-fec-add-xdp-and-page-pool-statistics/20221109-103338
patch link:    https://lore.kernel.org/r/20221109023147.242904-1-shenwei.wang%40nxp.com
patch subject: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool statistics
config: powerpc-randconfig-r031-20221110
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/fd502c1d977612cf562038959936bbde7b331685
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shenwei-Wang/net-fec-add-xdp-and-page-pool-statistics/20221109-103338
        git checkout fd502c1d977612cf562038959936bbde7b331685
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/ethernet/freescale/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_page_pool_stats':
>> drivers/net/ethernet/freescale/fec_main.c:2744:16: error: variable 'stats' has initializer but incomplete type
    2744 |         struct page_pool_stats stats = {};
         |                ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/freescale/fec_main.c:2744:32: error: storage size of 'stats' isn't known
    2744 |         struct page_pool_stats stats = {};
         |                                ^~~~~
>> drivers/net/ethernet/freescale/fec_main.c:2754:17: error: implicit declaration of function 'page_pool_get_stats'; did you mean 'phy_ethtool_get_stats'? [-Werror=implicit-function-declaration]
    2754 |                 page_pool_get_stats(rxq->page_pool, &stats);
         |                 ^~~~~~~~~~~~~~~~~~~
         |                 phy_ethtool_get_stats
   drivers/net/ethernet/freescale/fec_main.c:2744:32: warning: unused variable 'stats' [-Wunused-variable]
    2744 |         struct page_pool_stats stats = {};
         |                                ^~~~~
   cc1: some warnings being treated as errors


vim +/stats +2744 drivers/net/ethernet/freescale/fec_main.c

  2741	
  2742	static void fec_enet_page_pool_stats(struct fec_enet_private *fep, u64 *data)
  2743	{
> 2744		struct page_pool_stats stats = {};
  2745		struct fec_enet_priv_rx_q *rxq;
  2746		int i;
  2747	
  2748		for (i = fep->num_rx_queues - 1; i >= 0; i--) {
  2749			rxq = fep->rx_queue[i];
  2750	
  2751			if (!rxq->page_pool)
  2752				continue;
  2753	
> 2754			page_pool_get_stats(rxq->page_pool, &stats);
  2755		}
  2756	
  2757		page_pool_ethtool_stats_get(data, &stats);
  2758	}
  2759	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (178832 bytes)