linux-kernel - Re: [PATCH v6 11/20] dt-bindings: PCI: dwc: Add clocks/resets common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 14:04:48 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Vinod Koul <vkoul@...nel.org>, Frank Li <Frank.Li@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Krzysztof Wilczyński <kw@...ux.com>,
        linux-pci@...r.kernel.org, Robin Murphy <robin.murphy@....com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jingoo Han <jingoohan1@...il.com>,
        caihuoqing <caihuoqing@...du.com>
Subject: Re: [PATCH v6 11/20] dt-bindings: PCI: dwc: Add clocks/resets common
 properties

On Thu, Nov 10, 2022 at 03:23:37PM -0600, Rob Herring wrote:
> 
> On Mon, 07 Nov 2022 23:49:25 +0300, Serge Semin wrote:
> > DW PCIe RP/EP reference manuals explicit define all the clocks and reset
> > requirements in [1] and [2]. Seeing the DW PCIe vendor-specific
> > DT-bindings have already started assigning random names to the same set of
> > the clocks and resets lines, let's define a generic names sets and add
> > them to the DW PCIe common DT-schema.
> > 
> > Note since there are DW PCI-based vendor-specific DT-bindings with the
> > custom names assigned to the same clocks and resets resources we have no
> > much choice but to add them to the generic DT-schemas in order to have the
> > schemas being applicable for such devices. These names are marked as
> > vendor-specific and should be avoided being used in new bindings in favor
> > of the generic names.
> > 
> > [1] Synopsys DesignWare Cores PCI Express Controller Databook - DWC PCIe
> > Root Port, Version 5.40a, March 2019, p.55 - 78.
> > [2] Synopsys DesignWare Cores PCI Express Controller Databook - DWC PCIe
> > Endpoint, Version 5.40a, March 2019, p.58 - 81.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > 
> > ---
> > 
> > Changelog v3:
> > - This is a new patch unpinned from the next one:
> >   https://lore.kernel.org/linux-pci/20220503214638.1895-2-Sergey.Semin@baikalelectronics.ru/
> >   by the Rob' request. (@Rob)
> > - Drop synonymous from the names list since the device schemas create
> >   their own enumerations anyway.
> > 
> > Changelog v5:
> > - Add platform-specific clock/reset names, but mark them as deprecated.
> > 
> > Changelog v6:
> > - Move the common *-names definitions to the RP/EP schemas. Thus drop
> >   the 'definitions' property. (@Rob)
> > - Drop the 'deprecated' keywords from the vendor-specific names. (@Rob)
> > ---
> >  .../bindings/pci/snps,dw-pcie-common.yaml     | 120 ++++++++++++++++++
> >  .../bindings/pci/snps,dw-pcie-ep.yaml         |   6 +
> >  .../devicetree/bindings/pci/snps,dw-pcie.yaml |   2 -
> >  3 files changed, 126 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Yahoo! We've finally done this) Thanks.

-Sergey