linux-kernel - RE: [PATCH] srcu: Make Tiny SRCU synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 11:09:26 +0000
From:   "Zhang, Qiang1" <qiang1.zhang@...el.com>
To:     "paulmck@...nel.org" <paulmck@...nel.org>
CC:     "frederic@...nel.org" <frederic@...nel.org>,
        "joel@...lfernandes.org" <joel@...lfernandes.org>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] srcu: Make Tiny SRCU synchronize_srcu() more complete

On Wed, Nov 09, 2022 at 03:36:38PM +0800, Zqiang wrote:
> This commit add lockdep detection for illegal use synchronize_srcu()
> in same-type SRCU (or in RCU) read-side critical section and support
> early boot operations.
> 
> Signed-off-by: Zqiang <qiang1.zhang@...el.com>
>
>Queued and pushed with the usual wordsmithing (please check), thank you!

Thanks for  wordsmithing,  I have seen the new commit message 😊.

>
>							Thanx, Paul
>
> ---
>  kernel/rcu/srcutiny.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
> index 33adafdad261..b12fb0cec44d 100644
> --- a/kernel/rcu/srcutiny.c
> +++ b/kernel/rcu/srcutiny.c
> @@ -197,6 +197,16 @@ void synchronize_srcu(struct srcu_struct *ssp)
>  {
>  	struct rcu_synchronize rs;
>  
> +	RCU_LOCKDEP_WARN(lockdep_is_held(ssp) ||
> +			lock_is_held(&rcu_bh_lock_map) ||
> +			lock_is_held(&rcu_lock_map) ||
> +			lock_is_held(&rcu_sched_lock_map),
> +			"Illegal synchronize_srcu() in same-type SRCU (or in RCU) read-side critical section");
> +
> +	if (rcu_scheduler_active == RCU_SCHEDULER_INACTIVE)
> +		return;
> +
> +	might_sleep();
>  	init_rcu_head_on_stack(&rs.head);
>  	init_completion(&rs.completion);
>  	call_srcu(ssp, &rs.head, wakeme_after_rcu);
> -- 
> 2.25.1
>