linux-kernel - Re: [PATCH v2 3/5] firmware: ti_sci: Allocate memory for the LPM modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 21:00:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Georgi Vlaev <g-vlaev@...com>, Nishanth Menon <nm@...com>,
        Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Vibhore Vardhan <vibhore@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Georgi Vlaev <g-vlaev@...com>
Subject: Re: [PATCH v2 3/5] firmware: ti_sci: Allocate memory for the LPM
 modes

Hi Georgi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on f0c4d9fc9cc9462659728d168387191387e903cc]

url:    https://github.com/intel-lab-lkp/linux/commits/Georgi-Vlaev/firmware-ti_sci-Introduce-system-suspend-support/20221109-064746
base:   f0c4d9fc9cc9462659728d168387191387e903cc
patch link:    https://lore.kernel.org/r/20221108224527.137179-4-g-vlaev%40ti.com
patch subject: [PATCH v2 3/5] firmware: ti_sci: Allocate memory for the LPM modes
config: arm-randconfig-r011-20221111
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/4ac0e207de172d504b6bcbf299c892e915327bf9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Georgi-Vlaev/firmware-ti_sci-Introduce-system-suspend-support/20221109-064746
        git checkout 4ac0e207de172d504b6bcbf299c892e915327bf9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/firmware/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/firmware/ti_sci.c:3519:37: warning: shift count >= width of type [-Wshift-count-overflow]
                                          (u32)(info->ctx_mem_addr >> 32), 0);
                                                                   ^  ~~
   1 warning generated.


vim +3519 drivers/firmware/ti_sci.c

  3496	
  3497	static int ti_sci_init_suspend(struct platform_device *pdev,
  3498				       struct ti_sci_info *info)
  3499	{
  3500		struct device *dev = &pdev->dev;
  3501		int ret;
  3502	
  3503		dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
  3504		info->ctx_mem_buf = dma_alloc_coherent(info->dev, LPM_CTX_MEM_SIZE,
  3505						       &info->ctx_mem_addr,
  3506						       GFP_KERNEL);
  3507		if (!info->ctx_mem_buf) {
  3508			dev_err(info->dev, "Failed to allocate LPM context memory\n");
  3509			return -ENOMEM;
  3510		}
  3511	
  3512		/*
  3513		 * Attempt to call prepare_sleep, this will be NAK'd if suspend is not
  3514		 * supported by firmware in use, in which case we will not attempt to
  3515		 * init suspend.
  3516		 */
  3517		ret = ti_sci_cmd_prepare_sleep(&info->handle, 0,
  3518					       (u32)(info->ctx_mem_addr & 0xffffffff) ,
> 3519					       (u32)(info->ctx_mem_addr >> 32), 0);
  3520	
  3521		if (ret)
  3522			goto err;
  3523	
  3524		return 0;
  3525	err:
  3526		dma_free_coherent(info->dev, LPM_CTX_MEM_SIZE,
  3527				  info->ctx_mem_buf,
  3528				  info->ctx_mem_addr);
  3529		return ret;
  3530	}
  3531	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (167616 bytes)