linux-kernel - Re: [PATCH] modules: add modalias file to sysfs for modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211120823.k6hJxaXg-lkp@intel.com>
Date:   Sat, 12 Nov 2022 08:17:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Allen Webb <allenwebb@...gle.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Allen Webb <allenwebb@...gle.com>
Subject: Re: [PATCH] modules: add modalias file to sysfs for modules.

Hi Allen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus mcgrof/modules-next usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Allen-Webb/modules-add-modalias-file-to-sysfs-for-modules/20221111-233314
patch link:    https://lore.kernel.org/r/20221111152852.2837363-1-allenwebb%40google.com
patch subject: [PATCH] modules: add modalias file to sysfs for modules.
config: sparc-allyesconfig
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6dda398b2e01f44f8fb5f03116ba5e6143360140
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Allen-Webb/modules-add-modalias-file-to-sysfs-for-modules/20221111-233314
        git checkout 6dda398b2e01f44f8fb5f03116ba5e6143360140
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/base/mod_devicetable.c:214:9: warning: no previous prototype for 'usb_drv_to_modalias' [-Wmissing-prototypes]
     214 | ssize_t usb_drv_to_modalias(struct device_driver *drv, char *buf,
         |         ^~~~~~~~~~~~~~~~~~~


vim +/usb_drv_to_modalias +214 drivers/base/mod_devicetable.c

   203	
   204	/* Print the modaliases for the given driver assumed to be an usb_driver or
   205	 * usb_device_driver.
   206	 *
   207	 * "alias" is prepended and the module name is appended to each modalias to
   208	 * match the format in modules.aliases.
   209	 *
   210	 * The modaliases will be written out to @buf with @count being the maximum
   211	 * bytes to write. The return value is a negative errno on error or the number
   212	 * of bytes written to @buf on success.
   213	 */
 > 214	ssize_t usb_drv_to_modalias(struct device_driver *drv, char *buf,

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322188 bytes)