linux-kernel - Re: [syzbot] WARNING in snd_usbmidi_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Nov 2022 15:10:21 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     syzbot <syzbot+9abda841d636d86c41da@...kaller.appspotmail.com>,
        alsa-devel-owner@...a-project.org, alsa-devel@...a-project.org,
        clemens@...isch.de, gregkh@...uxfoundation.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org, peda@...ntia.se,
        perex@...ex.cz, rafael@...nel.org, syzkaller-bugs@...glegroups.com,
        tiwai@...e.com
Subject: Re: [syzbot] WARNING in snd_usbmidi_output_open

On Sat, 12 Nov 2022 14:35:06 +0100,
Mark Brown wrote:
> 
> On Sat, Nov 12, 2022 at 05:29:21AM -0800, syzbot wrote:
> > syzbot has bisected this issue to:
> > 
> > commit 4f8ed19593872b710f27bbc3b7a9ce03310efc57
> > Author: Mark Brown <broonie@...nel.org>
> > Date:   Thu Jun 2 13:10:58 2022 +0000
> > 
> >     ASoC: tfa9879: Use modern ASoC DAI format terminology
> 
> This bisection really doesn't seem credible for an issue in a different
> driver...  The tfa9879 is neither a USB nor MIDI device, and the commit
> in question is a stylistic update.

Yes, the bisection result is bogus.

And, the problem here is just a kernel WARNING produced by
snd_BUG_ON() macro usage, and the check itself is valid.
We just need to drop snd_BUG_ON() wrapping.

Will submit the fix later.


thanks,

Takashi