linux-kernel - Re: [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7241fb97-c7f7-2136-e93a-b498bcedf5e4@paragon-software.com>
Date:   Sat, 12 Nov 2022 21:18:05 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Daniel Pinto <danielpinto52@...il.com>, <ntfs3@...ts.linux.dev>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option



On 10/10/22 14:27, Daniel Pinto wrote:
> Changes v1->v2:
> - Add documentation for hidedotfiles mount option.
> 
> The current implementation of the hidedotfiles has some problems, namely:
> - there is a bug where enabling it actually disables it and vice versa
> - it only works when creating files, not when moving or renaming them
> - it is not listed in the enabled options list by the mount command
> - its name differs from the equivalent hide_dot_files mount option
>    used by NTFS-3G, making it incompatible with it for no reason
> 
> This series of patches tries to fix those problems.
> 
> Daniel Pinto (5):
>    fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
>    fs/ntfs3: make hidedotfiles mount option work when renaming files
>    fs/ntfs3: add hidedotfiles to the list of enabled mount options
>    fs/ntfs3: document the hidedotfiles mount option
>    fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
> 
>   Documentation/filesystems/ntfs3.rst | 6 ++++++
>   fs/ntfs3/frecord.c                  | 9 +++++++++
>   fs/ntfs3/inode.c                    | 2 +-
>   fs/ntfs3/super.c                    | 6 ++++--
>   4 files changed, 20 insertions(+), 3 deletions(-)

Good catch with differences between NTFS-3G and ntfs3.
Applied, thanks!