linux-kernel - Re: [PATCH] ata: ep93xx: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <413631cb-b9fa-b148-9dc7-ccca6047ace4@opensource.wdc.com>
Date:   Sat, 12 Nov 2022 11:11:59 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     ye.xingchen@....com.cn, s.shtylyov@....ru
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        chi.minghao@....com.cn
Subject: Re: [PATCH] ata: ep93xx: use devm_platform_get_and_ioremap_resource()

On 11/11/22 17:47, ye.xingchen@....com.cn wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>  drivers/ata/pata_ep93xx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> index 6c75a22db12b..47845d920075 100644
> --- a/drivers/ata/pata_ep93xx.c
> +++ b/drivers/ata/pata_ep93xx.c
> @@ -931,8 +931,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
>  		goto err_rel_gpio;
>  	}
> 
> -	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ide_base = devm_ioremap_resource(&pdev->dev, mem_res);
> +	ide_base = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
>  	if (IS_ERR(ide_base)) {
>  		err = PTR_ERR(ide_base);
>  		goto err_rel_gpio;

Applied to for-6.2 with the title chaged to "ata: pata_ep93xx: use...".
Thanks !

-- 
Damien Le Moal
Western Digital Research