linux-kernel - Re: [PATCH v4] i2c/pasemi: PASemi I2C controller IRQ enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3ADGNw6iDEDTezl@shikoro>
Date:   Sat, 12 Nov 2022 21:33:28 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Arminder Singh <arminders208@...look.com>
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org,
        Paul Mackerras <paulus@...ba.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Sven Peter <sven@...npeter.dev>,
        Hector Martin <marcan@...can.st>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        asahi@...ts.linux.dev
Subject: Re: [PATCH v4] i2c/pasemi: PASemi I2C controller IRQ enablement

On Sat, Nov 05, 2022 at 07:56:49AM -0400, Arminder Singh wrote:
> This patch adds IRQ support to the PASemi I2C controller driver to
> increase the performace of I2C transactions on platforms with PASemi I2C
> controllers. While primarily intended for Apple silicon platforms, this
> patch should also help in enabling IRQ support for older PASemi hardware
> as well should the need arise.
> 
> This version of the patch has been tested on an M1 Ultra Mac Studio,
> as well as an M1 MacBook Pro, and userspace launches successfully
> while using the IRQ path for I2C transactions.
> 
> Signed-off-by: Arminder Singh <arminders208@...look.com>

Applied to for-next, thanks! One thing, though:

> +		while (!(status & SMSTA_XEN) && timeout--) {
> +			msleep(1);

Checkpatch complained about this one:

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst

Not your issue because you were just moving this code around. But this
might be a candidate for future improvements, thiugh.

> +			status = reg_read(smbus, REG_SMSTA);
> +		}


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)