linux-kernel - Re: [PATCH net 1/2] mfd/ptp: clockmatrix: support 32-bit address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211121209.klpgYBXJ-lkp@intel.com>
Date:   Sat, 12 Nov 2022 12:40:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Min Li <min.li.xe@...esas.com>, richardcochran@...il.com,
        lee.jones@...aro.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Min Li <min.li.xe@...esas.com>
Subject: Re: [PATCH net 1/2] mfd/ptp: clockmatrix: support 32-bit address
 space

Hi Min,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Min-Li/mfd-ptp-clockmatrix-support-32-bit-address-space/20221112-041119
patch link:    https://lore.kernel.org/r/20221111200911.6505-1-min.li.xe%40renesas.com
patch subject: [PATCH net 1/2] mfd/ptp: clockmatrix: support 32-bit address space
config: riscv-randconfig-r033-20221111
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/8c173792ded55a67f9a7895633ac3e8a99871a02
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Min-Li/mfd-ptp-clockmatrix-support-32-bit-address-space/20221112-041119
        git checkout 8c173792ded55a67f9a7895633ac3e8a99871a02
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/ptp/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/ptp/ptp_idt82p33.c:132:12: error: call to undeclared function 'TOD_TRIGGER'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           trigger = TOD_TRIGGER(HW_TOD_WR_TRIG_SEL_MSB_TOD_CNFG,
                     ^
   drivers/ptp/ptp_idt82p33.c:172:12: error: call to undeclared function 'TOD_TRIGGER'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           trigger = TOD_TRIGGER(HW_TOD_WR_TRIG_SEL_MSB_TOD_CNFG,
                     ^
   drivers/ptp/ptp_idt82p33.c:287:12: error: call to undeclared function 'TOD_TRIGGER'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           trigger = TOD_TRIGGER(HW_TOD_WR_TRIG_SEL_MSB_TOD_CNFG,
                     ^
   3 errors generated.


vim +/TOD_TRIGGER +132 drivers/ptp/ptp_idt82p33.c

57a10d8c112306 Min Li 2020-02-21  123  
57a10d8c112306 Min Li 2020-02-21  124  static int _idt82p33_gettime(struct idt82p33_channel *channel,
57a10d8c112306 Min Li 2020-02-21  125  			     struct timespec64 *ts)
57a10d8c112306 Min Li 2020-02-21  126  {
57a10d8c112306 Min Li 2020-02-21  127  	struct idt82p33 *idt82p33 = channel->idt82p33;
57a10d8c112306 Min Li 2020-02-21  128  	u8 buf[TOD_BYTE_COUNT];
57a10d8c112306 Min Li 2020-02-21  129  	u8 trigger;
57a10d8c112306 Min Li 2020-02-21  130  	int err;
57a10d8c112306 Min Li 2020-02-21  131  
57a10d8c112306 Min Li 2020-02-21 @132  	trigger = TOD_TRIGGER(HW_TOD_WR_TRIG_SEL_MSB_TOD_CNFG,
57a10d8c112306 Min Li 2020-02-21  133  			      HW_TOD_RD_TRIG_SEL_LSB_TOD_STS);
57a10d8c112306 Min Li 2020-02-21  134  
57a10d8c112306 Min Li 2020-02-21  135  
57a10d8c112306 Min Li 2020-02-21  136  	err = idt82p33_write(idt82p33, channel->dpll_tod_trigger,
57a10d8c112306 Min Li 2020-02-21  137  			     &trigger, sizeof(trigger));
57a10d8c112306 Min Li 2020-02-21  138  
57a10d8c112306 Min Li 2020-02-21  139  	if (err)
57a10d8c112306 Min Li 2020-02-21  140  		return err;
57a10d8c112306 Min Li 2020-02-21  141  
57a10d8c112306 Min Li 2020-02-21  142  	if (idt82p33->calculate_overhead_flag)
57a10d8c112306 Min Li 2020-02-21  143  		idt82p33->start_time = ktime_get_raw();
57a10d8c112306 Min Li 2020-02-21  144  
57a10d8c112306 Min Li 2020-02-21  145  	err = idt82p33_read(idt82p33, channel->dpll_tod_sts, buf, sizeof(buf));
57a10d8c112306 Min Li 2020-02-21  146  
57a10d8c112306 Min Li 2020-02-21  147  	if (err)
57a10d8c112306 Min Li 2020-02-21  148  		return err;
57a10d8c112306 Min Li 2020-02-21  149  
57a10d8c112306 Min Li 2020-02-21  150  	idt82p33_byte_array_to_timespec(ts, buf);
57a10d8c112306 Min Li 2020-02-21  151  
57a10d8c112306 Min Li 2020-02-21  152  	return 0;
57a10d8c112306 Min Li 2020-02-21  153  }
57a10d8c112306 Min Li 2020-02-21  154  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (209581 bytes)