lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 13 Nov 2022 21:48:46 +0800
From:   kernel test robot <oliver.sang@...el.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
CC:     <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH v3] hw_random: use add_hwgenerator_randomness() for early
 entropy


Greeting,

FYI, we noticed WARNING:at_kernel/kthread.c:#kthread_should_stop due to commit (built with gcc-11):

commit: cea83a6b31856293ceab2c6ebab7843322fe105e ("[PATCH v3] hw_random: use add_hwgenerator_randomness() for early entropy")
url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20221106-230344/Jason-A-Donenfeld/hw_random-use-add_hwgenerator_randomness-for-early-entropy/20221106-044656
base: https://git.kernel.org/cgit/linux/kernel/git/gregkh/char-misc.git 30a0b95b1335e12efef89dd78518ed3e4a71a763
patch subject: [PATCH v3] hw_random: use add_hwgenerator_randomness() for early entropy

in testcase: stress-ng
version: stress-ng-x86_64-0.11-06_20221109
with following parameters:

	nr_threads: 100%
	testtime: 60s
	class: cpu
	test: str
	cpufreq_governor: performance



on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz (Cascade Lake) with 512G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):


If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <oliver.sang@...el.com>
| Link: https://lore.kernel.org/oe-lkp/202211132159.cd70b1c0-oliver.sang@intel.com


[   23.856915][    T1] ------------[ cut here ]------------
[ 23.862386][ T1] WARNING: CPU: 48 PID: 1 at kernel/kthread.c:75 kthread_should_stop (kernel/kthread.c:75 kernel/kthread.c:157) 
[   23.871363][    T1] Modules linked in:
[   23.875261][    T1] CPU: 48 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc3-00001-gcea83a6b3185 #1
[   23.884138][    T1] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.02.01.0008.031920191559 03/19/2019
[ 23.895447][ T1] RIP: 0010:kthread_should_stop (kernel/kthread.c:75 kernel/kthread.c:157) 
[ 23.901164][ T1] Code: 00 0f 1f 44 00 00 65 48 8b 04 25 00 ad 01 00 f6 40 2e 20 74 15 48 8b 80 08 0a 00 00 48 8b 00 48 d1 e8 83 e0 01 c3 cc cc cc cc <0f> 0b eb e7 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 84 00 00 00 00
All code
========
   0:	00 0f                	add    %cl,(%rdi)
   2:	1f                   	(bad)  
   3:	44 00 00             	add    %r8b,(%rax)
   6:	65 48 8b 04 25 00 ad 	mov    %gs:0x1ad00,%rax
   d:	01 00 
   f:	f6 40 2e 20          	testb  $0x20,0x2e(%rax)
  13:	74 15                	je     0x2a
  15:	48 8b 80 08 0a 00 00 	mov    0xa08(%rax),%rax
  1c:	48 8b 00             	mov    (%rax),%rax
  1f:	48 d1 e8             	shr    %rax
  22:	83 e0 01             	and    $0x1,%eax
  25:	c3                   	retq   
  26:	cc                   	int3   
  27:	cc                   	int3   
  28:	cc                   	int3   
  29:	cc                   	int3   
  2a:*	0f 0b                	ud2    		<-- trapping instruction
  2c:	eb e7                	jmp    0x15
  2e:	66 66 2e 0f 1f 84 00 	data16 nopw %cs:0x0(%rax,%rax,1)
  35:	00 00 00 00 
  39:	0f                   	.byte 0xf
  3a:	1f                   	(bad)  
  3b:	84 00                	test   %al,(%rax)
  3d:	00 00                	add    %al,(%rax)
	...

Code starting with the faulting instruction
===========================================
   0:	0f 0b                	ud2    
   2:	eb e7                	jmp    0xffffffffffffffeb
   4:	66 66 2e 0f 1f 84 00 	data16 nopw %cs:0x0(%rax,%rax,1)
   b:	00 00 00 00 
   f:	0f                   	.byte 0xf
  10:	1f                   	(bad)  
  11:	84 00                	test   %al,(%rax)
  13:	00 00                	add    %al,(%rax)
	...
[   23.920849][    T1] RSP: 0000:ffffc90000073b20 EFLAGS: 00010246
[   23.926910][    T1] RAX: ffff888100df0000 RBX: 0000000000000000 RCX: 0000000000000000
[   23.934914][    T1] RDX: 000000000000000e RSI: 0000000000000296 RDI: ffffffff830d57b8
[   23.942914][    T1] RBP: 0000000000000296 R08: 00000000c7b95e77 R09: 00000000294e6f92
[   23.950912][    T1] R10: 000000000defdd81 R11: 00000000f09cfad9 R12: ffff88c0882c1700
[   23.958911][    T1] R13: 0000000000000020 R14: 0000000000000000 R15: 00000000001b15d1
[   23.966910][    T1] FS:  0000000000000000(0000) GS:ffff88bf7fc00000(0000) knlGS:0000000000000000
[   23.975872][    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   23.982459][    T1] CR2: 0000000000000000 CR3: 000000807ee0a001 CR4: 00000000007706e0
[   23.990463][    T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   23.998463][    T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[   24.006470][    T1] PKRU: 55555554
[   24.010006][    T1] Call Trace:
[   24.013282][    T1]  <TASK>
[ 24.016220][ T1] add_hwgenerator_randomness (drivers/char/random.c:885) 
[ 24.021853][ T1] hwrng_register (drivers/char/hw_random/core.c:590) 
[ 24.026528][ T1] tpm_chip_register (drivers/char/tpm/tpm-chip.c:254) 
[ 24.031981][ T1] tpm_tis_core_init.cold (drivers/char/tpm/tpm_tis_core.c:1107) 
[ 24.037355][ T1] tpm_tis_plat_probe (drivers/char/tpm/tpm_tis.c:324) 
[ 24.042294][ T1] platform_probe (drivers/base/platform.c:1400) 
[ 24.046797][ T1] really_probe (drivers/base/dd.c:560 drivers/base/dd.c:639) 
[ 24.051207][ T1] ? pm_runtime_barrier (arch/x86/include/asm/paravirt.h:596 arch/x86/include/asm/qspinlock.h:57 include/linux/spinlock.h:203 include/linux/spinlock_api_smp.h:158 include/linux/spinlock.h:400 drivers/base/power/runtime.c:1413) 
[ 24.056227][ T1] __driver_probe_device (drivers/base/dd.c:719 drivers/base/dd.c:776) 
[ 24.061416][ T1] driver_probe_device (drivers/base/dd.c:808) 
[ 24.066347][ T1] __driver_attach (drivers/base/dd.c:1191) 
[ 24.071020][ T1] ? __device_attach_driver (drivers/base/dd.c:1135) 
[ 24.076558][ T1] ? __device_attach_driver (drivers/base/dd.c:1135) 
[ 24.082097][ T1] bus_for_each_dev (drivers/base/bus.c:301) 
[ 24.086774][ T1] bus_add_driver (drivers/base/bus.c:618) 
[ 24.091443][ T1] driver_register (drivers/base/driver.c:246) 
[ 24.096116][ T1] ? tpm_init (drivers/char/tpm/tpm_tis.c:379) 
[ 24.100263][ T1] init_tis (drivers/char/tpm/tpm_tis.c:386) 
[ 24.104250][ T1] ? tpm_init (drivers/char/tpm/tpm_tis.c:379) 
[ 24.108399][ T1] ? ktime_get (kernel/time/timekeeping.c:195 (discriminator 3) kernel/time/timekeeping.c:289 (discriminator 3) kernel/time/timekeeping.c:388 (discriminator 3) kernel/time/timekeeping.c:848 (discriminator 3)) 
[ 24.112637][ T1] ? tpm_init (drivers/char/tpm/tpm_tis.c:379) 
[ 24.116789][ T1] do_one_initcall (init/main.c:1303) 
[ 24.121461][ T1] do_initcalls (init/main.c:1375 init/main.c:1392) 
[ 24.125784][ T1] kernel_init_freeable (init/main.c:1635) 
[ 24.130978][ T1] ? rest_init (init/main.c:1511) 
[ 24.135386][ T1] kernel_init (init/main.c:1521) 
[ 24.139711][ T1] ret_from_fork (arch/x86/entry/entry_64.S:306) 
[   24.144122][    T1]  </TASK>
[   24.147143][    T1] ---[ end trace 0000000000000000 ]---


To reproduce:

        git clone https://github.com/intel/lkp-tests.git
        cd lkp-tests
        sudo bin/lkp install job.yaml           # job file is attached in this email
        bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
        sudo bin/lkp run generated-yaml-file

        # if come across any failure that blocks the test,
        # please remove ~/.lkp and /lkp dir to run from a clean state.



-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



View attachment "config-6.1.0-rc3-00001-gcea83a6b3185" of type "text/plain" (166032 bytes)

View attachment "job-script" of type "text/plain" (8429 bytes)

Download attachment "dmesg.xz" of type "application/x-xz" (32868 bytes)

View attachment "job.yaml" of type "text/plain" (5278 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ