linux-kernel - Re: [PATCH v7 1/3] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Nov 2022 16:50:04 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Kumar Gala <galak@...eaurora.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v7 1/3] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id

Hi Bjorn, Krzysztof,

On Mon, 26 Sept 2022 at 13:30, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 30/08/2022 08:57, Krzysztof Kozlowski wrote:
> > The top level qcom,msm-id and qcom,board-id properties are utilized by
> > bootloaders on Qualcomm MSM platforms to determine which device tree
> > should be used and passed to the kernel.
> >
> > The commit b32e592d3c28 ("devicetree: bindings: Document qcom board
> > compatible format") from 2015 was a consensus during discussion about
> > upstreaming qcom,msm-id and qcom,board-id fields.  There are however still
> > problems with that consensus:
> > 1. It was reached 7 years ago but it turned out its implementation did
> >    not reach all possible products.
> >
> > 2. Initially additional tool (dtbTool) was needed for parsing these
> >    fields to create a QCDT image consisting of multiple DTBs, later the
> >    bootloaders were improved and they use these qcom,msm-id and
> >    qcom,board-id properties directly.
> >
> > 3. Extracting relevant information from the board compatible requires
> >    this additional tool (dtbTool), which makes the build process more
> >    complicated and not easily reproducible (DTBs are modified after the
> >    kernel build).
> >
> > 4. Some versions of Qualcomm bootloaders expect these properties even
> >    when booting with a single DTB.  The community is stuck with these
> >    bootloaders thus they require properties in the DTBs.
> >
> > Since several upstreamed Qualcomm SoC-based boards require these
> > properties to properly boot and the properties are reportedly used by
> > bootloaders, document them along with the bindings header with constants
> > used by: bootloader, some DTS and socinfo driver.
> >
> > Link: https://lore.kernel.org/r/a3c932d1-a102-ce18-deea-18cbbd05ecab@linaro.org/
> > Co-developed-by: Kumar Gala <galak@...eaurora.org>
> > Signed-off-by: Kumar Gala <galak@...eaurora.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> >
> > ---
> >
> > Changes since v6:
> > 1. Update header with defines
> > 2. Add Rb tag
>
> Hi Bjorn,
>
> Any further comments on this? Can it be applied?

A gracious ping from my side. I think it would be better to apply this
patch rather than having the undocumented and controversial propreties
in the device trees.

-- 
With best wishes
Dmitry