linux-kernel - linux-next: manual merge of the modules tree with the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221114104633.4961d175@canb.auug.org.au>
Date:   Mon, 14 Nov 2022 10:46:33 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Luis Chamberlain <mcgrof@...nel.org>,
        David Miller <davem@...emloft.net>
Cc:     Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Zhen Lei <thunder.leizhen@...wei.com>
Subject: linux-next: manual merge of the modules tree with the net-next tree

Hi all,

Today's linux-next merge of the modules tree got conflicts in:

  include/linux/module.h
  kernel/module/kallsyms.c

between commit:

  73feb8d5fa3b ("kallsyms: Make module_kallsyms_on_each_symbol generally available")

from the net-next tree and commit:

  90de88426f3c ("livepatch: Improve the search performance of module_kallsyms_on_each_symbol()")

from the modules tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc include/linux/module.h
index 35876e89eb93,3b312a1fcf59..000000000000
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@@ -879,17 -878,8 +878,17 @@@ static inline bool module_sig_ok(struc
  }
  #endif	/* CONFIG_MODULE_SIG */
  
 +#if defined(CONFIG_MODULES) && defined(CONFIG_KALLSYMS)
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 					     struct module *, unsigned long),
+ int module_kallsyms_on_each_symbol(const char *modname,
+ 				   int (*fn)(void *, const char *, unsigned long),
  				   void *data);
 +#else
- static inline int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 						 struct module *, unsigned long),
- 						 void *data)
++static inline int module_kallsyms_on_each_symbol(const char *modname,
++						 int (*fn)(void *, const char *, unsigned long),
++						 void *data);
 +{
 +	return -EOPNOTSUPP;
 +}
 +#endif  /* CONFIG_MODULES && CONFIG_KALLSYMS */
  
  #endif /* _LINUX_MODULE_H */
diff --cc kernel/module/kallsyms.c
index 4523f99b0358,329cef573675..000000000000
--- a/kernel/module/kallsyms.c
+++ b/kernel/module/kallsyms.c
@@@ -494,8 -494,9 +494,8 @@@ unsigned long module_kallsyms_lookup_na
  	return ret;
  }
  
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 					     struct module *, unsigned long),
 -#ifdef CONFIG_LIVEPATCH
+ int module_kallsyms_on_each_symbol(const char *modname,
+ 				   int (*fn)(void *, const char *, unsigned long),
  				   void *data)
  {
  	struct module *mod;

Content of type "application/pgp-signature" skipped