linux-kernel - Re: [GIT PULL] arm64 updates for 6.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3JWpCV1LoScdJn1@arm.com>
Date:   Mon, 14 Nov 2022 14:54:28 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Will Deacon <will@...nel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        Bjorn Andersson <andersson@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [GIT PULL] arm64 updates for 6.1-rc1

On Mon, Nov 14, 2022 at 02:09:04PM +0000, Will Deacon wrote:
> On Sat, Nov 12, 2022 at 12:48:20AM +0530, Manivannan Sadhasivam wrote:
> > I digged a little further and found that the crash was due to the secure
> > processor (XPU) violation. It happens because, CPU tried acccessing the memory
> > after sharing it with the modem for firmware metadata validation.
[...]
> > Sibi tried fixing this problem earlier by using a hack in the remoteproc driver
> > [1], but I guess that got negated due to c44094eee32f?
> 
> Performing a clean rather than a clean+invalidate when the buffer is
> allocated (which is what is achieved by c44094eee32f) shouldn't affect
> this afaict.

I agree. The DMA_ATTR_NO_KERNEL_MAPPING used in the qcom_q6v5_mss fix
only ensures that there is no non-cacheable DMA mapping but we still
have the kernel linear map in place that may be accessed speculatively
by the CPU at any point. I can't tell why the clean+inval makes any
difference but I suspect it's a matter of time before you'd hit similar
conditions again (maybe not at boot).

-- 
Catalin