linux-kernel - Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6df463da-1065-025f-b104-dea5c0bd0dcd@linaro.org>
Date:   Mon, 14 Nov 2022 16:53:26 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Will Deacon <will@...nel.org>
Cc:     Melody Olvera <quic_molvera@...cinc.com>,
        Joerg Roedel <joro@...tes.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000
 iommu implementation

On 14/11/2022 15:42, Will Deacon wrote:
> On Mon, Nov 14, 2022 at 03:28:15PM +0100, Krzysztof Kozlowski wrote:
>> On 26/10/2022 21:05, Melody Olvera wrote:
>>> Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu
>>> support for them.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>>> ---
>>>  drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> index b2708de25ea3..0580a381a04b 100644
>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
>>>  static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
>>>  	{ .compatible = "qcom,msm8998-smmu-v2" },
>>>  	{ .compatible = "qcom,qcm2290-smmu-500" },
>>> +	{ .compatible = "qcom,qdu1000-smmu-500" },
>>
>> The patch was applied but it contradicts work here:
>> https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/
>> which explicitly asks not to add such compatibles...
> 
> Sure, but we've been adding new compatibles for years so I don't mind
> picking up the last few now before we stop accepting new ones.
> 
> I already asked Dmitry to respin his series as there are some open comments
> from others anyway.

OK. This also solves my other comment for other patch.

Best regards,
Krzysztof