linux-kernel - Re: [PATCH][V2] hid: intel-ish-hid: ishtp: remove variable rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2211141725050.6045@cbobk.fhfr.pm>
Date:   Mon, 14 Nov 2022 17:25:10 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
cc:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Even Xu <even.xu@...el.com>, linux-input@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] hid: intel-ish-hid: ishtp: remove variable
 rb_count

On Thu, 20 Oct 2022, Colin Ian King wrote:

> The variable rb_count is being incremented but it
> is never referenced, it is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> V2: Fix commit message.
> ---
>  drivers/hid/intel-ish-hid/ishtp/client.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c
> index df0a825694f5..2d92fc129ce4 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client.c
> @@ -841,7 +841,6 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev,
>  	unsigned char *buffer = NULL;
>  	struct ishtp_cl_rb *complete_rb = NULL;
>  	unsigned long	flags;
> -	int	rb_count;
>  
>  	if (ishtp_hdr->reserved) {
>  		dev_err(dev->devc, "corrupted message header.\n");
> @@ -855,9 +854,7 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev,
>  	}
>  
>  	spin_lock_irqsave(&dev->read_list_spinlock, flags);
> -	rb_count = -1;
>  	list_for_each_entry(rb, &dev->read_list.list, list) {
> -		++rb_count;
>  		cl = rb->cl;
>  		if (!cl || !(cl->host_client_id == ishtp_hdr->host_addr &&
>  				cl->fw_client_id == ishtp_hdr->fw_addr) ||

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs