[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <PAXPR04MB91854E3A8555B067FDEFBED089059@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date: Mon, 14 Nov 2022 16:31:46 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Andrew Lunn <andrew@...n.ch>
CC: Alexander Lobakin <alexandr.lobakin@...el.com>,
Paolo Abeni <pabeni@...hat.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
statistics
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, November 14, 2022 10:28 AM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: Alexander Lobakin <alexandr.lobakin@...el.com>; Paolo Abeni
> <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Alexei
> Starovoitov <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> Jesper Dangaard Brouer <hawk@...nel.org>; John Fastabend
> <john.fastabend@...il.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; imx@...ts.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
> statistics
>
> Caution: EXT Email
>
> > I did implement a quick version of u64_stats_t counters, and the
> > performance impact was about 1~3Mbps on the i.MX8QXP which is 1.2GHz
> > ARM64 Dual Core platform, which is about 1.5% performance decrease.
>
> Please post your code.
>
> Which driver did you copy? Maybe you picked a bad example?
The implementation was not optimized because it updated the u64_stats_t counters per packet.
Thanks,
Shenwei
>
> Andrew
Powered by blists - more mailing lists