linux-kernel - Re: [PATCH v15 8/8] arm64: dts: qcom: sm8250: Add tpdm mm/prng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea17f523-a21f-6af8-7aec-db0a5825f6b2@linaro.org>
Date:   Mon, 14 Nov 2022 17:45:22 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mao Jinlong <quic_jinlmao@...cinc.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...il.com>,
        Mike Leach <mike.leach@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Leo Yan <leo.yan@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Tao Zhang <quic_taozha@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH v15 8/8] arm64: dts: qcom: sm8250: Add tpdm mm/prng

On 14/11/2022 15:40, Mao Jinlong wrote:
> Add tpdm mm and tpdm prng for sm8250.
> 
> +---------------+                +-------------+
> |  tpdm@...8000 |                |tpdm@...C000 |
> +-------|-------+                +------|------+
>         |                               |
> +-------|-------+                       |
> | funnel@...b000|                       |
> +-------|-------+                       |
>         |                               |
> +-------|-------+                       |
> |funnel@...d000 |                       |
> +-------|-------+                       |
>         |                               |
>         |    +---------------+          |
>         +----- tpda@...4000  -----------+
>              +-------|-------+
>                      |
>              +-------|-------+
>              |funnel@...5000 |
>              +---------------+
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 173 +++++++++++++++++++++++++++
>  1 file changed, 173 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 80193bb3c478..0914b4b9c862 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2746,6 +2746,76 @@
>  			};
>  		};
>  
> +		tpda@...4000 {
> +			compatible = "arm,primecell";

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

I don't think your bindings allow this to be alone...

Beside, your patch does not apply. Is it based on Bjorn's tree?

> +			reg = <0 0x06004000 0 0x1000>;
> +			reg-names = "tpda-base";
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					tpda_out_funnel_qatb: endpoint {
> +						remote-endpoint = <&funnel_qatb_in_tpda>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@9 {
> +					reg = <9>;
> +					tpda_9_in_tpdm_mm: endpoint {
> +						remote-endpoint = <&tpdm_mm_out_tpda9>;
> +					};
> +				};
> +
> +				port@17 {
> +					reg = <23>;
> +					tpda_23_in_tpdm_prng: endpoint {
> +						remote-endpoint = <&tpdm_prng_out_tpda_23>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...5000 {
> +			compatible = "arm,primecell";

Same problem, I guess.


Best regards,
Krzysztof