lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221114171103.GA917836@bhelgaas>
Date:   Mon, 14 Nov 2022 11:11:03 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Liu Peibao <liupeibao@...ngson.cn>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof WilczyƄski <kw@...ux.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>,
        wanghongliang <wanghongliang@...ngson.cn>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5] PCI: loongson: Skip scanning unavailable child devices

Hi Liu,

On Mon, Nov 14, 2022 at 03:43:46PM +0800, Liu Peibao wrote:
> The PCI Controller of 2K1000 could not mask devices by setting vender ID or
> device ID in configuration space header as invalid values.

I don't think this 2K1000 information is really relevant.  I
understand that some chipsets might support this, and they might use
that to avoid this issue, but there's no PCI requirement that the
Vendor/Device ID be writable by anything.

> When there are
> pins shareable between the platform device and the on chip PCI device, if

What does "pins shareable between the platform device and the on chip
PCI device" mean?

I assume there's a single device in the hardware, and both the
"platform device" and the PCI device" refer to that single device?

And there's some reason you prefer to use the platform device
interface to enumerate that device?

> the platform device is preferred, we should not scan this PCI device. In
> the above scene, add `status = "disabled"` property in DT node of this PCI
> device.
> 
> Before this patch, to solve the above problem, we treat the on chip PCI
> devices as platform devices with fixed address assigned by the BIOS.

This says "before this patch".  But the rest of the sentence sounds
like what happens *after* this patch.

> When
> there is device not preferred, add the `status = "disabled"` property in DT
> node.

> In kernel, the PCI host bridge only scans slot 9/A/B/C/D/E that are
> bridges.

I guess this has something to do with pdev_may_exist() [1], but why do
you mention it here?  Do you intend to remove pdev_may_exist() and use
this DT mechanism instead?

Bjorn

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/pci-loongson.c?id=v6.0#n168

> Overall, this looks not much elegant.
> 
> Signed-off-by: Liu Peibao <liupeibao@...ngson.cn>
> ---
> V4 -> V5: make the issue we are facing clear in commit log.
> V3 -> V4: 1. get rid of the masklist and search the status property
> 	  directly.
>           2. check the status property only when accessing the vendor ID.
> V2 -> V3: 1. use list_for_each_entry() for more clearly.
>           2. fix wrong use of sizeof().
> V1 -> V2: use existing property "status" instead of adding new property.
> 
>  drivers/pci/controller/pci-loongson.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c
> index 05c50408f13b..efca0b3b5a29 100644
> --- a/drivers/pci/controller/pci-loongson.c
> +++ b/drivers/pci/controller/pci-loongson.c
> @@ -194,6 +194,17 @@ static void __iomem *pci_loongson_map_bus(struct pci_bus *bus,
>  			return NULL;
>  	}
>  
> +#ifdef CONFIG_OF
> +	/* Don't access disabled devices. */
> +	if (pci_is_root_bus(bus) && where == PCI_VENDOR_ID) {
> +		struct device_node *dn;
> +
> +		dn = of_pci_find_child_device(bus->dev.of_node, devfn);
> +		if (dn && !of_device_is_available(dn))
> +			return NULL;
> +	}
> +#endif
> +
>  	/* CFG0 can only access standard space */
>  	if (where < PCI_CFG_SPACE_SIZE && priv->cfg0_base)
>  		return cfg0_map(priv, bus, devfn, where);
> -- 
> 2.20.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ