linux-kernel - Re: [PATCH] virt/kvm: Replace "unsigned" with "unsigned int"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3J4YqiJemzz1Nrg@google.com>
Date:   Mon, 14 Nov 2022 17:18:26 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     wangjianli <wangjianli@...rlc.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt/kvm: Replace "unsigned" with "unsigned int"

On Sun, Nov 13, 2022, wangjianli wrote:
> Replace "unsigned" with "unsigned int"
> 
> Signed-off-by: wangjianli <wangjianli@...rlc.com>
> ---
>  virt/kvm/irqchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
> index 58e4f88b2b9f..eefea6a650fb 100644
> --- a/virt/kvm/irqchip.c
> +++ b/virt/kvm/irqchip.c
> @@ -38,7 +38,7 @@ int kvm_irq_map_gsi(struct kvm *kvm,
>  	return n;
>  }
>  
> -int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin)
> +int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned int irqchip, unsigned int pin)

I'm all for opportunistically cleaning these up, but IMO it's not worth churning
code just to fix use of bare unsigned.  And if we are going to fix them, fix them
_all_, and fix the prototypes, e.g. from just a few relevant declarations:

int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin);  <=====

int kvm_set_irq(struct kvm *kvm, int irq_source_id, u32 irq, int level,
		bool line_status);
int kvm_set_msi(struct kvm_kernel_irq_routing_entry *irq_entry, struct kvm *kvm,
		int irq_source_id, int level, bool line_status);
int kvm_arch_set_irq_inatomic(struct kvm_kernel_irq_routing_entry *e,
			       struct kvm *kvm, int irq_source_id,
			       int level, bool line_status);
bool kvm_irq_has_notifier(struct kvm *kvm, unsigned irqchip, unsigned pin);  <=====

void kvm_notify_acked_gsi(struct kvm *kvm, int gsi);
void kvm_notify_acked_irq(struct kvm *kvm, unsigned irqchip, unsigned pin);  <=====