linux-kernel - Re: [PATCH v1 1/4] list: Introduce list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3J/KUBu3adGPiwT@casper.infradead.org>
Date:   Mon, 14 Nov 2022 17:47:21 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     kernel test robot <lkp@...el.com>,
        Jakob Koschel <jakobkoschel@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        oe-kbuild-all@...ts.linux.dev, Kevin Cernekee <cernekee@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH v1 1/4] list: Introduce list_count() to count existing
 nodes

On Mon, Nov 14, 2022 at 06:03:00PM +0200, Andy Shevchenko wrote:
> Oh, nice! I will fix this for v2.

list_count() is an antipattern.  I don't have any of the patches in
my inbox, so maybe there's a great reason for doing this, but my
immediate response is: NAK.