linux-kernel - Re: [PATCH v6 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 01:49:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Marvin Lin <milkfafa@...il.com>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, openbmc@...ts.ozlabs.org,
        avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        kwliu@...oton.com, kflin@...oton.com,
        Marvin Lin <milkfafa@...il.com>
Subject: Re: [PATCH v6 5/5] drivers: media: platform: Add NPCM Video
 Capture/Encode Engine driver

Hi Marvin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next sailus-media-tree/streams linus/master v6.1-rc5 next-20221114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Marvin-Lin/Support-Nuvoton-NPCM-Video-Capture-Encode-Engine/20221104-114045
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221104033810.1324686-6-milkfafa%40gmail.com
patch subject: [PATCH v6 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver
config: m68k-randconfig-s052-20221114
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/5327cbbd89482bccd939416dd77bc7ba3cb14ba2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Marvin-Lin/Support-Nuvoton-NPCM-Video-Capture-Encode-Engine/20221104-114045
        git checkout 5327cbbd89482bccd939416dd77bc7ba3cb14ba2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/platform/nuvoton/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/media/platform/nuvoton/npcm-video.c:352:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *addr @@     got void * @@
   drivers/media/platform/nuvoton/npcm-video.c:352:27: sparse:     expected void const volatile [noderef] __iomem *addr
   drivers/media/platform/nuvoton/npcm-video.c:352:27: sparse:     got void *
>> drivers/media/platform/nuvoton/npcm-video.c:1184:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void * @@     got void [noderef] __iomem *[assigned] baseptr @@
   drivers/media/platform/nuvoton/npcm-video.c:1184:9: sparse:     expected void *
   drivers/media/platform/nuvoton/npcm-video.c:1184:9: sparse:     got void [noderef] __iomem *[assigned] baseptr

vim +352 drivers/media/platform/nuvoton/npcm-video.c

   335	
   336	static unsigned int npcm_video_ece_get_ed_size(struct npcm_video *video,
   337						       u32 offset, void *addr)
   338	{
   339		struct regmap *ece = video->ece.regmap;
   340		u32 size, gap, val;
   341		int ret;
   342	
   343		ret = regmap_read_poll_timeout(ece, ECE_DDA_STS, val,
   344					       (val & ECE_DDA_STS_CDREADY),
   345					       0, ECE_POLL_TIMEOUT_US);
   346	
   347		if (ret) {
   348			dev_warn(video->dev, "Wait for ECE_DDA_STS_CDREADY timeout\n");
   349			return 0;
   350		}
   351	
 > 352		size = readl(addr + offset);
   353	
   354		regmap_read(ece, ECE_HEX_CTRL, &val);
   355		gap = FIELD_GET(ECE_HEX_CTRL_ENC_GAP, val);
   356	
   357		dev_dbg(video->dev, "offset = %u, ed_size = %u, gap = %u\n", offset,
   358			size, gap);
   359	
   360		return size + gap;
   361	}
   362	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (144354 bytes)